build: fix building when there is only python3 by zcbenz · Pull Request #48462 · nodejs/node · GitHub

On some environments, especially macOS, there is only python3 and no python, replacing the python to <(python) can make gyp use the correct python.

Review requested:

@nodejs/gyp
@nodejs/v8-update

This breaks all CI. I also have this changes on my macOS too.

The error is:

gyp: Undefined variable python in /home/runner/work/node/node/tools/v8_gypfiles/v8.gyp while loading dependencies of /home/runner/work/node/node/node.gyp while trying to load /home/runner/work/node/node/node.gyp

Failed to start CI

- Validating Jenkins credentials
✘  Jenkins credentials invalid

https://github.com/nodejs/node/actions/runs/5295843320

Failed to start CI

- Validating Jenkins credentials
✘  Jenkins credentials invalid

https://github.com/nodejs/node/actions/runs/5298312237

CI: https://ci.nodejs.org/job/node-test-pull-request/52378/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5409/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5409/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5409/

CI: https://ci.nodejs.org/job/node-test-pull-request/52379/

broken on windows arm64 cc @nodejs/platform-arm @StefanStojanovic

11:04:03   'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:03   operable program or batch file.
11:04:03 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'out\Release\\node_js2c_host.exe;src\inspector\node_protocol.pdl;src\inspector\node_protocol_config.json;deps\v8\include\js_protocol.pdl;out\Release\\obj\global_intermediate\concatenated_protocol.json;deps\openssl\openssl\util\libcrypto.num' exited with code 1. [C:\workspace\node-compile-windows\node\libnode.vcxproj]
11:04:03   gen-regexp-special-case.cc
11:04:03 C:\workspace\node-compile-windows\node\deps\v8\src\base\bits.h(448,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\gen-regexp-special-case_host.vcxproj]
11:04:04      Creating library ..\..\out\Release\gen-regexp-special-case_host.lib and object ..\..\out\Release\gen-regexp-special-case_host.exp
11:04:04   gen-regexp-special-case_host.vcxproj -> ..\..\out\Release\\gen-regexp-special-case_host.exe
11:04:05   run_gen-regexp-special-case_action
11:04:05   'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:05   operable program or batch file.
11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case.vcxproj]
11:04:05   run_gen-regexp-special-case_action
11:04:05   'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:05   operable program or batch file.
11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case_host.vcxproj]
11:04:05 
11:04:05 > if errorlevel 1 (
11:04:05 if not defined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen"

This should also upstream to https://github.com/nodejs/gyp-next

Landed in d1ccca9

PR-URL: #48462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: nodejs/node#48462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jun 15, 2023

lpinca approved these changes Jun 15, 2023

View reviewed changes

gengjiawen requested changes Jun 16, 2023

View reviewed changes

gengjiawen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 17, 2023

gengjiawen approved these changes Jun 17, 2023

View reviewed changes

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2023

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 17, 2023

gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 17, 2023

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 17, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023

This was referenced Jun 24, 2023

CI Reliability 2023-06-24 nodejs/reliability#597

Open

CI Reliability 2023-06-25 nodejs/reliability#598

Open

gengjiawen reviewed Oct 24, 2023

View reviewed changes

github-actions Bot mentioned this pull request Oct 25, 2023

CI Reliability 2023-10-25 nodejs/reliability#697

Open

16 tasks

zcbenz mentioned this pull request Oct 25, 2023

fix: add quotes for command in msvs generator nodejs/gyp-next#217

Merged

gengjiawen approved these changes Oct 25, 2023

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2023

nodejs-github-bot merged commit d1ccca9 into nodejs:main Oct 25, 2023

github-actions Bot mentioned this pull request Oct 26, 2023

CI Reliability 2023-10-26 nodejs/reliability#698

Open

20 tasks

targos pushed a commit that referenced this pull request Nov 11, 2023

build: fix building when there is only python3

54ebfc1

PR-URL: #48462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023

build: fix building when there is only python3

cfd50f2

PR-URL: #48462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024

build: fix building when there is only python3

da96ac6

PR-URL: nodejs/node#48462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

avivkeller mentioned this pull request Apr 22, 2025

build: define python when generating out/Makefile #57970

Merged

nodejs-github-bot pushed a commit that referenced this pull request Apr 27, 2025

build: define python when generating out/Makefile

c712dd2

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

build: define python when generating out/Makefile

df48d16

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

build: define python when generating out/Makefile

0049139

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

build: define python when generating out/Makefile

63aa6f0

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

build: define python when generating out/Makefile

73938fe

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

build: define python when generating out/Makefile

2a43cbf

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

build: define python when generating out/Makefile

898b404

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

build: define python when generating out/Makefile

0270102

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

build: define python when generating out/Makefile

0b49b77

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 19, 2025

build: define python when generating out/Makefile

e5bf67f

PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

                           # Convert any paths to native form (first element is used directly).
                           # TODO(quote):  regularize quoting path names throughout the module
+                          command[1] = '"%s"' % command[1]
                           arguments = ['"%s"' % i for i in arguments]

build: fix building when there is only python3 by zcbenz · Pull Request #48462 · nodejs/node · GitHub

Uh oh!

Uh oh!

build: fix building when there is only python3 - #48462

build: fix building when there is only python3#48462nodejs-github-bot merged 5 commits intonodejs:mainnodejs/node:mainfrom zcbenz:patch-8zcbenz/node:patch-8Copy head branch name to clipboard

Conversation

zcbenz commented Jun 15, 2023

Uh oh!

nodejs-github-bot commented Jun 15, 2023

Uh oh!

gengjiawen left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Jun 16, 2023

Uh oh!

github-actions Bot commented Jun 17, 2023

Uh oh!

github-actions Bot commented Jun 17, 2023

Uh oh!

nodejs-github-bot commented Jun 23, 2023

Uh oh!

nodejs-github-bot commented Jun 23, 2023

Uh oh!

nodejs-github-bot commented Jun 23, 2023

Uh oh!

nodejs-github-bot commented Jun 23, 2023

Uh oh!

nodejs-github-bot commented Jun 23, 2023

Uh oh!

gengjiawen commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

build: fix building when there is only python3#48462
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
zcbenz:patch-8

gengjiawen commented Jun 23, 2023 •
edited
Loading