FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: define python when generating `out/Makefile` by avivkeller · Pull Request #57970 · nodejs/node · GitHub

/ node Public

build: define python when generating out/Makefile - #57970

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-851593
Apr 27, 2025
ConversationCommits (1)ChecksFiles changed
Merged

build: define python when generating out/Makefile#57970
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-851593

Conversation

avivkeller commented Apr 22, 2025

Copy link
Copy Markdown
Member

Ref: #48462

Equal to

node/configure.py

Lines 2363 to 2372 in d74c498

# Remove the trailing .exe from the executable name, otherwise the python.exe
# would be rewrote as python_host.exe due to hack in GYP for supporting cross
# compilation on Windows.
# See https://github.com/nodejs/node/pull/32867 for related change.
python = sys.executable
if flavor == 'win' and python.lower().endswith('.exe'):
python = python[:-4]
# Always set 'python' variable, otherwise environments that only have python3
# will fail to run python scripts.
gyp_args += ['-Dpython=' + python]

When out/Makefile is generated during ./configure, -Dpython= is passed to GYP, however, when it's generated from the Makefile, it is not passed. This can lead to an undefined variable python on some systems.

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 22, 2025

codecov Bot commented Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (d12ee6e) to head (8b8afa1).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57970      +/-   ##
==========================================
- Coverage   90.26%   89.73%   -0.53%     
==========================================
  Files         630      630              
  Lines      186170   186170              
  Branches    36478    36164     -314     
==========================================
- Hits       168042   167066     -976     
- Misses      10982    11937     +955     
- Partials     7146     7167      +21

see 101 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2025

nodejs-github-bot commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66429/

nodejs-github-bot commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66430/

jakecastelli added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 24, 2025
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
nodejs-github-bot merged commit c712dd2 into nodejs:main Apr 27, 2025

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

Landed in c712dd2

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
build: define python when generating out/Makefile
df48d16 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
build: define python when generating out/Makefile
0049139 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
build: define python when generating out/Makefile
63aa6f0 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
build: define python when generating out/Makefile
73938fe 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
build: define python when generating out/Makefile
2a43cbf 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
build: define python when generating out/Makefile
898b404 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
build: define python when generating out/Makefile
0270102 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
build: define python when generating out/Makefile
0b49b77 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
build: define python when generating out/Makefile
e5bf67f 
PR-URL: #57970
Refs: #48462
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL