esm: unflag import.meta.resolve by guybedford · Pull Request #49028 · nodejs/node · GitHub

Unflags import.meta.resolve making the second parentURL argument still gated behind the same --experimental-import-meta-resolve flag so that existing users would retain backwards compatibility, while the default behaviour becomes standards compliant.

If we can combine this approach with supporting file:/// URLs in fetch, that would be a powerful new approach for cross-platform asset loading - await (await fetch(import.meta.resolve('./asset.bin'))).arrayBuffer() which hopefully in turn bundlers should also be able to support better too.

//cc @nodejs/modules

Review requested:

@nodejs/loaders
@nodejs/modules

Looks good, but should we add some docs to esm.md?

The last time I tried this it had a ton of bugs and gaps; can you confirm that anything that import() or import can reach, import.meta.resolve can produce a URL for?

@ljharb right, as pointed out in #49010, this still seemed to be the case. I've pushed a fix with this PR and updated the description to note that we now always provide the resolution when exact modules are not found, while not found package names will still throw not found.

I feel like bugfixes should go in their own PR, not be coupled with unflagging.

I don’t think bugs need to necessarily hold up unflagging. We fix bugs in unflagged/stable APIs all the time. If there are any other known open bugs related to import.meta.resolve, it would be good to fix them before unflagging, but if not then I’m fine with unflagging and continuing to bugfix as users report issues.

Will it remain experimental despite being unflagged?

I can split the changes out if it would be preferred, but I think the only thing that would really affect is backporting - and I think it would be fine to backport this change without a concern too.

I've split out the not found fix into #49038, so this should now land after that.

🙌 Good call converting the flag to affect only parentURL

CI: https://ci.nodejs.org/job/node-test-pull-request/53221/

CI: https://ci.nodejs.org/job/node-test-pull-request/53225/

@guybedford I think what's happening in the ASan job that's failing is that the overall test file is timing out. Each subtest is taking 5 seconds or so. Perhaps this is a real error.

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Notable changes: deps: * V8: cherry-pick 93275031284c (Joyee Cheung) #48660 doc: * add new TSC members (Michael Dawson) #48841 * add rluvaton to collaborators (Raz Luvaton) #49215 esm: * unflag import.meta.resolve (Guy Bedford) #49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder) #48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder) #48559 inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow) #48765 module: * implement `register` utility (João Lenon) #46826 * make CJS load from ESM loader (Antoine du Hamel) #47999 src: * add built-in `.env` file support (Yagiz Nizipli) #48890 * initialize cppgc (Daryl Haresign and Joyee Cheung) #48660 and #45704 test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 PR-URL: #49185

PR-URL: #49247 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

import.meta.resolve was unflagged in Node.js 20.6 by nodejs/node#49028 Unfortunately, the unflagged version does not support the parentURL argument. Rather than attempting to detect whether the argument is supported (which is not as simple as .length testing) stop using it until a reliable version is unflagged. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

PR-URL: #49247 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

PR-URL: nodejs#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: nodejs#49247 Refs: nodejs#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

PR-URL: #49028 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: #49247 Backport-PR-URL: #50669 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 * (SEMVER-MINOR) upgrade npm to 10.0.0 (npm team) #49423 doc: * add new TSC members (Michael Dawson) #48841 * move and rename loaders section (Geoffrey Booth) #49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * unflag import.meta.resolve (Guy Bedford) #49028 * move hook execution to separate thread (Jacob Smith) #44710 * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) #49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 wasi: * (SEMVER-MINOR) updates required for latest uvwasi version (Michael Dawson) #49908 PR-URL: TODO

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) #50531 doc: * move and rename loaders section (Geoffrey Booth) #49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * unflag import.meta.resolve (Guy Bedford) #49028 * move hook execution to separate thread (Jacob Smith) #44710 * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) #49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 PR-URL: #50953

PR-URL: nodejs/node#49028 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: nodejs/node#49247 Backport-PR-URL: nodejs/node#50669 Refs: nodejs/node#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs/node#49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) nodejs/node#50531 doc: * move and rename loaders section (Geoffrey Booth) nodejs/node#49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs/node#49869 * unflag import.meta.resolve (Guy Bedford) nodejs/node#49028 * move hook execution to separate thread (Jacob Smith) nodejs/node#44710 * leverage loaders when resolving subsequent loaders (Maël Nison) nodejs/node#43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs/node#46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) nodejs/node#44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) nodejs/node#45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) nodejs/node#49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs/node#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs/node#49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs/node#48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs/node#48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs/node#47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs/node#49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs/node#45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50141 PR-URL: nodejs/node#50953

PR-URL: nodejs/node#49028 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: nodejs/node#49247 Backport-PR-URL: nodejs/node#50669 Refs: nodejs/node#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs/node#49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) nodejs/node#50531 doc: * move and rename loaders section (Geoffrey Booth) nodejs/node#49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs/node#49869 * unflag import.meta.resolve (Guy Bedford) nodejs/node#49028 * move hook execution to separate thread (Jacob Smith) nodejs/node#44710 * leverage loaders when resolving subsequent loaders (Maël Nison) nodejs/node#43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs/node#46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) nodejs/node#44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) nodejs/node#45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) nodejs/node#49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs/node#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs/node#49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs/node#48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs/node#48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs/node#47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs/node#49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs/node#45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50141 PR-URL: nodejs/node#50953

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 5, 2023

GeoffreyBooth approved these changes Aug 5, 2023

View reviewed changes

anonrig reviewed Aug 5, 2023

View reviewed changes

Comment thread lib/internal/modules/esm/initialize_import_meta.js Outdated

GeoffreyBooth approved these changes Aug 5, 2023

View reviewed changes

guybedford mentioned this pull request Aug 6, 2023

import.meta.resolve non existing paths. #49010

Closed

guybedford commented Aug 6, 2023

View reviewed changes

Comment thread doc/api/esm.md Outdated

guybedford force-pushed the import-meta-resolve-unflag branch from 5e75ebd to 36a1f5b Compare August 6, 2023 03:09

GeoffreyBooth approved these changes Aug 6, 2023

View reviewed changes

JakobJingleheimer approved these changes Aug 6, 2023

View reviewed changes

Comment thread lib/internal/modules/esm/initialize_import_meta.js Outdated

VoltrexKeyva approved these changes Aug 9, 2023

View reviewed changes

GeoffreyBooth removed the needs-ci PRs that need a full CI run. label Aug 12, 2023

github-actions Bot mentioned this pull request Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

29 tasks

guybedford and others added 6 commits August 12, 2023 19:47

esm: unflag import.meta.resolve

7797444

update pr url

719c418

replaceme

1c5c2d8

docs changes

f865a1d

pr feedback

69796fd

Update lib/internal/modules/esm/initialize_import_meta.js

09f2bef

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2023

doc: edit import.meta.resolve documentation

e11c7b7

PR-URL: #49247 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

koshic mentioned this pull request Sep 6, 2023

Breakage in Node.js v20.6.0 iambumblehead/esmock#234

Closed

nicolo-ribaudo mentioned this pull request Sep 8, 2023

Fix compatibility with Node.js 20.6 babel/babel#15947

Merged

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023

doc: edit import.meta.resolve documentation

b9d4a80

PR-URL: #49247 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023

doc: edit import.meta.resolve documentation

16580a4

PR-URL: nodejs#49247 Refs: nodejs#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos mentioned this pull request Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos added the backported-to-v18.x label Nov 23, 2023

targos pushed a commit that referenced this pull request Nov 23, 2023

doc: edit import.meta.resolve documentation

c20fdb4

PR-URL: #49247 Backport-PR-URL: #50669 Refs: #49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

sunrabbit123 mentioned this pull request Aug 12, 2024

fix: svelte should find other package on yarn pnp sveltejs/kit#12563

Closed

6 tasks

skyclouds2001 mentioned this pull request Nov 10, 2024

Fix spec_url & update nodejs data for import.meta.resolve mdn/browser-compat-data#25020

Merged

esm: unflag import.meta.resolve by guybedford · Pull Request #49028 · nodejs/node · GitHub

Uh oh!

Uh oh!

esm: unflag import.meta.resolve - #49028

esm: unflag import.meta.resolve#49028nodejs-github-bot merged 8 commits intonodejs:mainnodejs/node:mainfrom guybedford:import-meta-resolve-unflagguybedford/node:import-meta-resolve-unflagCopy head branch name to clipboard

Conversation

guybedford commented Aug 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 5, 2023

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ljharb commented Aug 5, 2023

Uh oh!

guybedford commented Aug 6, 2023

Uh oh!

GeoffreyBooth commented Aug 6, 2023

Uh oh!

ljharb commented Aug 6, 2023

Uh oh!

guybedford commented Aug 6, 2023

Uh oh!

Uh oh!

guybedford commented Aug 6, 2023

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

GeoffreyBooth commented Aug 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

esm: unflag import.meta.resolve#49028
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
guybedford:import-meta-resolve-unflag

guybedford commented Aug 5, 2023 •
edited
Loading