FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: edit `import.meta.resolve` documentation by aduh95 · Pull Request #49247 · nodejs/node · GitHub

/ node Public

doc: edit import.meta.resolve documentation - #49247

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:import-meta-resolve
Sep 5, 2023
ConversationCommits (3)ChecksFiles changed
Merged

doc: edit import.meta.resolve documentation#49247
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:import-meta-resolve

Conversation

aduh95 commented Aug 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • add missing history entry.
  • fix the return value description:
    • The return value doesn't have to be a file: URL, it can be of any scheme.
    • The return value doesn't have to correspond to a module, it can be a directory or something that doesn't exist.
  • merge the two code examples, remove the use of the non-standard second argument.
  • merge the two caveats.
  • do not mention the old implementation, the history section is already there for that.

Refs: #49028

nodejs-github-bot commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
JakobJingleheimer reviewed Aug 19, 2023
View reviewed changes
Comment thread doc/api/esm.md Outdated
Comment thread doc/api/esm.md Outdated
GeoffreyBooth approved these changes Aug 19, 2023
View reviewed changes
Comment thread doc/api/esm.md Outdated
Comment thread doc/api/esm.md Outdated
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 19, 2023
GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2023

github-actions Bot commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

GeoffreyBooth commented Aug 19, 2023 •
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Adding fast-track PRs that do not need to wait for 48 hours to land. in case it’s possible to add this to Monday’s release.

GeoffreyBooth mentioned this pull request Aug 19, 2023
Merged

joyeecheung commented Aug 27, 2023

Copy link
Copy Markdown
Member

This needs a rebase

aduh95 force-pushed the import-meta-resolve branch from 6f1be92 to d20e630 Compare September 4, 2023 21:02
aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2023
GeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
nodejs-github-bot merged commit e11c7b7 into nodejs:main Sep 5, 2023

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in e11c7b7

aduh95 deleted the import-meta-resolve branch September 5, 2023 08:06
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
doc: edit import.meta.resolve documentation
b9d4a80 
PR-URL: #49247
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
doc: edit import.meta.resolve documentation
16580a4 
PR-URL: nodejs#49247
Refs: nodejs#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
doc: edit import.meta.resolve documentation
c20fdb4 
PR-URL: #49247
Backport-PR-URL: #50669
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: edit import.meta.resolve documentation
11700d7 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: edit import.meta.resolve documentation
054b934 
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JakobJingleheimer JakobJingleheimer left review comments
GeoffreyBooth GeoffreyBooth approved these changes
guybedford guybedford approved these changes
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL