test: add tmpdir.resolve() - #49079
Merged
nodejs-github-bot merged 1 commit intoAug 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
LiviaMedeiros
force-pushed
the
test-ft-tmpdir-resolve
branch
from
550ddaf to
8d0bc39
Compare
August 10, 2023 12:30
Copy link
Copy Markdown
Contributor
|
It's a lot of files to review, and you are going to end up in a conflict hell. Maybe we can split this into several PRs? |
Sorry, something went wrong.
LiviaMedeiros
force-pushed
the
test-ft-tmpdir-resolve
branch
from
8d0bc39 to
3d3cc33
Compare
August 11, 2023 15:14
Copy link
Copy Markdown
Member
Author
|
Sure, I'll try to split test changes by subsystems after landing this one. |
Sorry, something went wrong.
This comment was marked as outdated.
aduh95
approved these changes
Aug 11, 2023
This comment was marked as outdated.
LiviaMedeiros
force-pushed
the
test-ft-tmpdir-resolve
branch
from
3d3cc33 to
c59cc3e
Compare
August 12, 2023 06:49
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 12, 2023
29 tasks
This was referenced Aug 13, 2023
25 tasks
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
22 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 16, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple method to make the usual routine of path.join(tmpdir.path, ...) more concise and avoid unnecessary import from node:path almost every time tmpdir is used.