FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v18.18.1 proposal by richardlau · Pull Request #50065 · nodejs/node · GitHub

/ node Public

v18.18.1 proposal - #50065

Closed
richardlau wants to merge 7 commits into
v18.xfrom
v18.18.1-proposal
Closed

v18.18.1 proposal#50065
richardlau wants to merge 7 commits into
v18.xfrom
v18.18.1-proposal

Conversation

Copy link
Copy Markdown
Member

2023-10-10, Version 18.18.1 'Hydrogen' (LTS), @richardlau

Notable Changes

This release addresses some regressions that appeared in Node.js 18.18.0:

  • (Windows) FS can not handle certain characters in file name #48673
  • 18 and 20 node images give error - Text file busy (after re-build images) nodejs/docker-node#1968
  • libuv update in 18.18.0 breaks webpack's thread-loader #49911

The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted.

Commits


cc @nodejs/lts

Note that this is not a "full" Node.js 18 release -- it is a "quick" release to fix the regressions noted above that were introduced in Node.js 18.18.0. I will not have time to do a full Node.js release this month, so any requests for additions to this release will likely be denied unless a very strong case can be made.

LiviaMedeiros and others added 7 commits September 28, 2023 12:05
PR-URL: #49079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
fs.write(v) is not guaranteed to write everything in a single
call. Make sure we don't assume so.

PR-URL: #49211
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
This reverts commit ea23870.

PR-URL: #50036
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
This reverts commit 7dc731d.

PR-URL: #50036
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
This reverts commit 88855e0.

PR-URL: #50036
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
This reverts commit fb2b80f.

PR-URL: #50036
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Notable changes:

This release addresses some regressions that appeared in Node.js 18.18.0:

- (Windows) FS can not handle certain characters in file name
  #48673
- 18 and 20 node images give error - Text file busy (after re-build images)
  nodejs/docker-node#1968
- libuv update in 18.18.0 breaks webpack's thread-loader
  #49911

The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0
have been temporarily reverted.

PR-URL: #50065

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 6, 2023
richardlau changed the base branch from main to v18.x-staging October 6, 2023 16:57
richardlau changed the base branch from v18.x-staging to v18.x October 6, 2023 16:57

anonrig commented Oct 6, 2023

Copy link
Copy Markdown
Member

@richardlau There are couple of bugs that Ada's latest releases fixed such as a segfault, and a crash on hostname setter. Since they're isolated commits, I recommend including them in this release.

Copy link
Copy Markdown
Member Author

@anonrig Those haven't been released in a current release yet so are not normally considered for inclusion in LTS.

Copy link
Copy Markdown
Member Author

Not sure what those lint failures are -- they're not in any of the files changed by this proposal. I'll close and open a new PR in case it was due to be swapping the base branch.

richardlau closed this Oct 6, 2023

anonrig commented Oct 6, 2023

Copy link
Copy Markdown
Member

@anonrig Those haven't been released in a current release yet so are not normally considered for inclusion in LTS.

Even though I agree, Ada's latest releases fixes easily reproducible cases/crashes in the most commonly used module in Node. If we can take an incentive to land them, I strongly recommend adding them. But in the end, it's your call and I respect that.

Copy link
Copy Markdown
Member Author

Not sure what those lint failures are -- they're not in any of the files changed by this proposal. I'll close and open a new PR in case it was due to be swapping the base branch.

#50066 -- linters are passing there so it must have been some issue with opening the PR on the wrong base branch.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL