FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add print results for examples in `WebStreams` by pluris · Pull Request #49143 · nodejs/node · GitHub

/ node Public

doc: add print results for examples in WebStreams - #49143

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
pluris:fix/missing_prints_webstream
Aug 15, 2023
ConversationCommits (2)ChecksFiles changed
Merged

doc: add print results for examples in WebStreams#49143
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
pluris:fix/missing_prints_webstream

Conversation

pluris commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

As with the other examples, I added something about the resulting output.(Only output results that do not change)

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 13, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 14, 2023
lpinca approved these changes Aug 14, 2023
View reviewed changes
Comment thread doc/api/webstreams.md Outdated

for await (const chunk of transformedStream)
console.log(chunk);
// Prints A

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints A
// Prints: A

Comment thread doc/api/webstreams.md Outdated
(async () => {
for await (const chunk of transformedStream)
console.log(chunk);
// Prints A

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints A
// Prints: A

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from(dataArray);
const data = await arrayBuffer(readable);
console.log(`from readable: ${data.byteLength}`);
// Prints from readable: 76

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 76
// Prints: from readable: 76

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from(dataArray);
arrayBuffer(readable).then((data) => {
console.log(`from readable: ${data.byteLength}`);
// Prints from readable: 76

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 76
// Prints: from readable: 76

Comment thread doc/api/webstreams.md Outdated
const readable = dataBlob.stream();
const data = await blob(readable);
console.log(`from readable: ${data.size}`);
// Prints from readable: 27

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 27
// Prints: from readable: 27

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from(dataBuffer);
buffer(readable).then((data) => {
console.log(`from readable: ${data.length}`);
// Prints from readable: 27

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 27
// Prints: from readable: 27

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from(JSON.stringify(items));
const data = await json(readable);
console.log(`from readable: ${data.length}`);
// Prints from readable: 100

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 100
// Prints: from readable: 100

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from(JSON.stringify(items));
json(readable).then((data) => {
console.log(`from readable: ${data.length}`);
// Prints from readable: 100

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 100
// Prints: from readable: 100

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from('Hello world from consumers!');
const data = await text(readable);
console.log(`from readable: ${data.length}`);
// Prints from readable: 27

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 27
// Prints: from readable: 27

Comment thread doc/api/webstreams.md Outdated
const readable = Readable.from('Hello world from consumers!');
text(readable).then((data) => {
console.log(`from readable: ${data.length}`);
// Prints from readable: 27

lpinca Aug 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Prints from readable: 27
// Prints: from readable: 27

lpinca commented Aug 14, 2023

Copy link
Copy Markdown
Member 
$ git grep "// Prints:" doc/ | wc -l
     505
$ git grep "// Prints " doc/ | wc -l
     115

pluris commented Aug 15, 2023

Copy link
Copy Markdown
Contributor Author

@lpinca Hi, thank you for your opinion.
They are mixed in both ways, but most of them use Prints: more.
I think the document I referenced wrote Prints. 😓
I fixed it.

lpinca added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 15, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2023
nodejs-github-bot merged commit 9a2e6bc into nodejs:main Aug 15, 2023

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9a2e6bc

RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
doc: add print results for examples in WebStreams
35738fd 
PR-URL: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
doc: add print results for examples in WebStreams
2ed105a 
PR-URL: nodejs#49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
doc: add print results for examples in WebStreams
2a9aa46 
PR-URL: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
doc: add print results for examples in WebStreams
21949c4 
PR-URL: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris mentioned this pull request Aug 25, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Aug 27, 2023
doc: add print results for examples in StringDecoder
b9153af 
PR-URL: #49326
Refs: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris deleted the fix/missing_prints_webstream branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
doc: add print results for examples in StringDecoder
73cfd9c 
PR-URL: #49326
Refs: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
doc: add print results for examples in StringDecoder
3f1a237 
PR-URL: #49326
Refs: #49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: add print results for examples in StringDecoder
79de017 
PR-URL: nodejs/node#49326
Refs: nodejs/node#49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
doc: add print results for examples in StringDecoder
872651a 
PR-URL: nodejs/node#49326
Refs: nodejs/node#49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
deokjinkim deokjinkim approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL