doc: add print results for examples in StringDecoder - #49326
Merged
nodejs-github-bot merged 1 commit intoAug 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mscdex
reviewed
Aug 25, 2023
Comment thread
doc/api/string_decoder.md
| decoder.write(Buffer.from([0xE2])); | ||
| decoder.write(Buffer.from([0x82])); | ||
| console.log(decoder.end(Buffer.from([0xAC]))); | ||
| console.log(decoder.end(Buffer.from([0xAC]))); // Prints: € |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Isn't this already implied by the text preceding this code block?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@mscdex It's implied, but I thought it would be nice to show the result. won't it be needed?
Sorry, something went wrong.
aduh95
approved these changes
Aug 25, 2023
deokjinkim
approved these changes
Aug 26, 2023
lpinca
approved these changes
Aug 26, 2023
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49326 Refs: nodejs/node#49143 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49326 Refs: nodejs/node#49143 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with the other examples, I added result about the output.
Refs: #49143