FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase coverage of `Module.register` and `initialize` hook by aduh95 · Pull Request #49532 · nodejs/node · GitHub

/ node Public

test: increase coverage of Module.register and initialize hook - #49532

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-initialize
Sep 10, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: increase coverage of Module.register and initialize hook#49532
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-initialize

Conversation

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

I recommend reviewing with whitespaces turned off.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 7, 2023

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/loaders

GeoffreyBooth commented Sep 7, 2023

Copy link
Copy Markdown
Member

How does this relate to #49529?

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 7, 2023

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

How does this relate to #49529?

Hum both PRs are dealing with the same Module.register API, but apart from that they are hardly related.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2023

GeoffreyBooth commented Sep 7, 2023

Copy link
Copy Markdown
Member

apart from that they are hardly related.

As in, none of these tests involve the initialize return value.

That’s fine, I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53791/

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

They probably are in conflict, they are modifying the same lines in the test, for unrelated reasons.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53847/

github-actions Bot mentioned this pull request Sep 10, 2023
Open
19 tasks
aduh95 mentioned this pull request Sep 10, 2023
Closed

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53851/

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53852/

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
nodejs-github-bot merged commit c159b90 into nodejs:main Sep 10, 2023

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in c159b90

This was referenced Sep 11, 2023
Open
Open
joyeecheung mentioned this pull request Sep 12, 2023
Closed
This was referenced Sep 13, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test: increase coverage of Module.register and initialize hook
ced25a9 
PR-URL: #49532
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: increase coverage of Module.register and initialize hook
89dce06 
PR-URL: nodejs#49532
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
test: increase coverage of Module.register and initialize hook
866d646 
PR-URL: #49532
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: increase coverage of Module.register and initialize
6ddeff5 
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: increase coverage of Module.register and initialize
2311dc2 
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL