esm: wrap initialize hook test-cases in describe block - #49581
Closed
GeoffreyBooth wants to merge 1 commit into
Closed
esm: wrap initialize hook test-cases in describe block#49581GeoffreyBooth wants to merge 1 commit into
GeoffreyBooth wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Isn’t that a duplicate of #49532 (minus the added tests)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Ah sorry I thought that one just added tests. Sure, we can close this in favor of that. |
Sorry, something went wrong.
This was referenced Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the tests for the initialize hook into a describe block, like the tests for the other hooks. This is split off from #49144 so that it can land and be backported without being blocked for backport like #49144.
It’s easier to review this if you hide whitespace changes. @nodejs/loaders