FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade to npm 2.14.16 by zkat · Pull Request #4960 · nodejs/node · GitHub

/ node Public

deps: upgrade to npm 2.14.16 - #4960

Closed
zkat wants to merge 2 commits into
nodejs:v4.x-stagingfrom
npm:npm-2.14.16
ConversationCommits (2)ChecksFiles changed
Closed

deps: upgrade to npm 2.14.16#4960
zkat wants to merge 2 commits into
nodejs:v4.x-stagingfrom
npm:npm-2.14.16

Conversation

zkat commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

Another day, another LTS!

The changelog for this version can be found here: https://github.com/npm/npm/releases/tag/v2.14.16

Interesting changes:

r: @Fishrock123
r: @iarna

zkat added npm Issues and PRs related to the npm client dependency or the npm registry. lts-watch-v4.x labels Jan 29, 2016

MylesBorins commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/1436/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/53/

It is worth mentioning the CI does not run make test-npm... but rather makes sure that these changes are not breaking general CI

zkat commented Jan 29, 2016

Copy link
Copy Markdown
Contributor Author

Noted! If you want, npm test-npm should be runnable on non-windows platforms now, but idk what CI plans for this are?

MylesBorins commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

Tests passing locally on OSX 10.10.5

MylesBorins commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

I opened an issue nodejs/build#317 to discuss CI plans

zkat mentioned this pull request Jan 29, 2016
Closed

Fishrock123 commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

make test-npm passes for me, LGTM

zkat commented Jan 29, 2016

Copy link
Copy Markdown
Contributor Author

@Fishrock123 Next release (v2.14.17) will include the patch for pre-releases without cherry-picking btw.

MylesBorins commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

So I went ahead and made a CI job for npm and am doing a test run

I'm expecting failures. To reduce noise I'll post updates in this comment

https://ci.nodejs.org/job/thealphanerd-npm/3/

Fishrock123 commented Jan 30, 2016

Copy link
Copy Markdown
Contributor

@zkat this doesn't include that? I didn't modify v4.x-staging at all and it passed.

Edit: can confirm I did indeed build the branch and instal before testing.

zkat commented Jan 30, 2016

Copy link
Copy Markdown
Contributor Author

@Fishrock123 Oh sorry, it wasn't clear: I included it as an extra patch cherry-picked from the last release, because it won't be included in npm itself until next week. See 24b8a5f

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM

zkat added 2 commits February 1, 2016 10:37
deps: upgrade to npm 2.14.16
f86c754 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: make npm tests work on prerelease node versions
bba3189 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
zkat added a commit that referenced this pull request Feb 1, 2016
deps: upgrade to npm 2.14.16
fc446ba 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
zkat added a commit that referenced this pull request Feb 1, 2016
test: make npm tests work on prerelease node versions
9a9ac8e 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

Looks like these commits are on the staging branch. Closing

landed in fcb8cae...9a9ac8e

MylesBorins closed this Feb 1, 2016
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
deps: upgrade to npm 2.14.16
3e76cb7 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
test: make npm tests work on prerelease node versions
967ebf5 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
deps: upgrade to npm 2.14.16
0b1822f 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
test: make npm tests work on prerelease node versions
bebf951 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
deps: upgrade to npm 2.14.16
393d652 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
test: make npm tests work on prerelease node versions
890e2ba 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
deps: upgrade to npm 2.14.16
976b9a9 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
test: make npm tests work on prerelease node versions
f78daa6 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
deps: upgrade to npm 2.14.16
632b6ca 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test: make npm tests work on prerelease node versions
a56724f 
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins removed their assignment Dec 27, 2016
wraithgar deleted the npm-2.14.16 branch June 26, 2025 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL