FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "test: mark test-http-regr-gh-2928 as flaky" by lpinca · Pull Request #49708 · nodejs/node · GitHub

/ node Public

Revert "test: mark test-http-regr-gh-2928 as flaky" - #49708

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:revert/pr-49565
Sep 20, 2023
Merged

Revert "test: mark test-http-regr-gh-2928 as flaky"#49708
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:revert/pr-49565

Conversation

lpinca commented Sep 18, 2023

Copy link
Copy Markdown
Member

This reverts commit 48fcb20.

Refs: 18e00a577d74

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 18, 2023
lpinca marked this pull request as ready for review September 18, 2023 18:22

Copy link
Copy Markdown
Member

Queued a stress test for this on win2016-vs2017, win2012r2-vs2015 (not sure if the job works on these two though) and FreeBSD https://ci.nodejs.org/job/node-stress-single-test/449

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

debadree25 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 20, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
nodejs-github-bot merged commit 480ab8c into nodejs:main Sep 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 480ab8c

lpinca deleted the revert/pr-49565 branch September 20, 2023 18:42
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
This reverts commit 48fcb20.

Refs: 18e00a577d74
PR-URL: #49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Sep 28, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
This reverts commit 48fcb20.

Refs: 18e00a577d74
PR-URL: #49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This reverts commit 48fcb20.

Refs: nodejs/node@18e00a577d74
PR-URL: nodejs/node#49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This reverts commit 48fcb20.

Refs: nodejs/node@18e00a577d74
PR-URL: nodejs/node#49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL