FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: accept `testOnly` in `run` by MoLow · Pull Request #49743 · nodejs/node · GitHub

/ node Public

test_runner: accept testOnly in run - #49743

Merged
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:run-accept-only
Sep 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: accept testOnly in run#49743
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:run-accept-only

Conversation

MoLow commented Sep 21, 2023

Copy link
Copy Markdown
Member

Fixes: #49733

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 21, 2023

MoLow commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

after this change --experimental-test-coverage is the last cli flag that cannot be passed to run (except for reporters - they should just use pipe), might be worth adding it as well. @cjihrig WDYT?

atlowChemi commented Sep 21, 2023

Copy link
Copy Markdown
Member

might be worth adding it as well

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

atlowChemi approved these changes Sep 21, 2023
View reviewed changes
Comment thread doc/api/test.md Outdated
Comment thread test/fixtures/test-runner/test_only.js Outdated

MoLow commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

I was not suggesting to add support for the reporter flags. was suggesting to add the coverage flag

MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Sep 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54117/

cjihrig commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

@cjihrig WDYT?

Sounds great to me.

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54143/

test_runner: catch reporter errors
a4c7f81 
PR-URL: nodejs#49646
Fixes: nodejs#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow merged commit a4c7f81 into nodejs:main Sep 21, 2023
MoLow deleted the run-accept-only branch September 21, 2023 20:24
MoLow mentioned this pull request Sep 21, 2023
Merged
This was referenced Sep 22, 2023
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes
atlowChemi Awaiting requested review from atlowChemi

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner: add 'testOnly' parameter to 'run' function

5 participants

Back | FazBrowse Home | New Git URL