FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: add support for `deflate-raw` format to webstreams compression by pirxpilot · Pull Request #50097 · nodejs/node · GitHub

/ node Public

stream: add support for deflate-raw format to webstreams compression - #50097

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pirxpilot:add-deflate-raw-support
Nov 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

stream: add support for deflate-raw format to webstreams compression#50097
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pirxpilot:add-deflate-raw-support

Conversation

pirxpilot commented Oct 9, 2023 •
edited by panva
Loading

Copy link
Copy Markdown
Contributor

this change makes deflate-raw a valid parameter for both CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream

Edit: Notable Change

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Oct 9, 2023
anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 9, 2023
anonrig reviewed Oct 9, 2023
View reviewed changes
Comment thread doc/api/webstreams.md Outdated
Comment thread doc/api/webstreams.md Outdated

github-actions Bot commented Oct 9, 2023 •
edited by panva
Loading

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

Edit: Notable Change

stream: add support for deflate-raw format to webstreams compression
0331b7a 
this change makes `deflate-raw` a valid parameter for both
CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers
support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream
tniessen requested a review from jasnell October 9, 2023 13:33
pirxpilot added a commit to furkot/import-kmz that referenced this pull request Oct 10, 2023
test naive polyfill for webstream deflate-raw
6663ff9 
needed until nodejs/node#50097 is released
wojpawlik mentioned this pull request Oct 15, 2023
Open
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023

This comment was marked as outdated.

Sign in to view
This was referenced Oct 22, 2023
Open
Open
Open

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55340/

This was referenced Nov 1, 2023
Open
Open
Open

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55516/

panva mentioned this pull request Nov 9, 2023
Closed
panva added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 9, 2023

panva commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Notable change text proposal:

The "deflate-raw" compression format was added to the CompressionStream and DecompressionStream APIs. This format has been recently added to other JS runtimes and its inclusion in Node.js improves interoperability of the API with these runtimes.

panva added the stream Issues and PRs related to the stream subsystem. label Nov 9, 2023
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023

panva commented Nov 9, 2023

Copy link
Copy Markdown
Member

@pirxpilot Thank you for working on this, amazing first contribution!

nodejs-github-bot merged commit 3e14cfb into nodejs:main Nov 9, 2023

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3e14cfb

panva commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I've opened a followup, #50631, to enable the compression WPTs and fix the constructor handling of the format argument to follow its WebIDL definition. For the rest I'll open an issue to document the other failing or skipped WPTs so that they may also be looked at by someone with deeper knowledge of the subsystem.

targos pushed a commit that referenced this pull request Nov 11, 2023
stream: add support for deflate-raw format to webstreams compression
44421cb 
this change makes `deflate-raw` a valid parameter for both
CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers
support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream
PR-URL: #50097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos added a commit that referenced this pull request Nov 12, 2023
2023-11-14, Version 21.2.0 (Current)
9183a07 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
targos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 13, 2023
2023-11-14, Version 21.2.0 (Current)
0f82899 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
targos pushed a commit that referenced this pull request Nov 14, 2023
stream: add support for deflate-raw format to webstreams compression
91f37d1 
this change makes `deflate-raw` a valid parameter for both
CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers
support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream
PR-URL: #50097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos added a commit that referenced this pull request Nov 14, 2023
2023-11-14, Version 21.2.0 (Current)
13b266f 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
targos added a commit that referenced this pull request Nov 14, 2023
2023-11-14, Version 21.2.0 (Current)
02db7fc 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
panva mentioned this pull request Dec 15, 2023
Closed
richardlau pushed a commit that referenced this pull request Mar 25, 2024
stream: add support for deflate-raw format to webstreams compression
ade6614 
this change makes `deflate-raw` a valid parameter for both
CompressionStream and DecompressionStream constructors

it makes node's implementation consistent with what modern browsers
support and what specification calls for

see: https://wicg.github.io/compression/#compression-stream
PR-URL: #50097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
coderabbitai Bot mentioned this pull request Jul 5, 2026
Merged
5 tasks
coderabbitai Bot mentioned this pull request Aug 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL