FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,stream: enable compression WPTs by panva · Pull Request #50631 · nodejs/node · GitHub

/ node Public

test,stream: enable compression WPTs - #50631

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:compression-wpt
ConversationCommits (2)ChecksFiles changed
Closed

test,stream: enable compression WPTs#50631
panva wants to merge 2 commits into
nodejs:mainfrom
panva:compression-wpt

Conversation

panva commented Nov 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

A followup to #50097

  • Enables the compression WPTs with the JSON status file reflecting the current status of the API in Node.js
  • Fixes the constructor handling of the format argument to follow its WebIDL definition

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 8, 2023
panva added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. stream Issues and PRs related to the stream subsystem. web streams needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. web streams labels Nov 8, 2023
panva changed the title streams: add deflate-raw to De/CompressionStream stream: add deflate-raw to De/CompressionStream Nov 8, 2023
panva added the experimental Issues and PRs related to experimental features. label Nov 8, 2023
panva marked this pull request as ready for review November 8, 2023 23:21
panva added semver-minor PRs that contain new features and should be released in the next minor version. request-ci Add this label to start a Jenkins CI on a PR. and removed experimental Issues and PRs related to experimental features. labels Nov 8, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

panva commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I didn't notice #50097, I'll push that over the line and turn this into just a PR enabling the WPTs to run and a couple small fixes.

panva added test Issues and PRs related to the tests. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 9, 2023
panva changed the title stream: add deflate-raw to De/CompressionStream test,stream: add compression tests to the WPT test suite Nov 9, 2023
panva marked this pull request as draft November 9, 2023 10:39
panva changed the title test,stream: add compression tests to the WPT test suite test,stream: add compression WPTs Nov 9, 2023
panva changed the title test,stream: add compression WPTs test,stream: enable compression WPTs Nov 9, 2023
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023

panva commented Nov 9, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/web-standards @nodejs/streams

I'll also open a separate issue to document the failing or skipped WPTs so that they may be investigated and subsequently possibly fixed by someone with deeper knowledge of the subsystem.

panva added the web-standards Issues and PRs related to Web APIs label Nov 9, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023

This comment was marked as outdated.

Sign in to view
panva mentioned this pull request Nov 9, 2023
Closed

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55526/

panva commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

preview: https://staging.wpt.fyi/results/compression?q=.any.html&run_id=6063987856769024&run_id=5143837821370368&run_id=4967230276108288

This was referenced Nov 10, 2023
Open
Open
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 11, 2023
github-actions Bot mentioned this pull request Nov 12, 2023
Open
18 tasks
mcollina approved these changes Nov 12, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023

nodejs-github-bot commented Nov 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 314c8f9...9d652f4

nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2023
test,stream: enable compression WPTs
635a5c8 
PR-URL: #50631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2023
stream: treat compression web stream format per its WebIDL definition
9d652f4 
PR-URL: #50631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
panva deleted the compression-wpt branch November 12, 2023 10:02
github-actions Bot mentioned this pull request Nov 13, 2023
Open
24 tasks
panva mentioned this pull request Nov 13, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
test,stream: enable compression WPTs
7ebc8c2 
PR-URL: #50631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
stream: treat compression web stream format per its WebIDL definition
146ad9c 
PR-URL: #50631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS mentioned this pull request Nov 28, 2023
Merged

panva commented Dec 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Backport blocked until #50097 is also backported.

panva mentioned this pull request Dec 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. web streams web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL