test: set test-esm-loader-resolve-type as flaky - #50226
Merged
nodejs-github-bot merged 1 commit intoOct 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
force-pushed
the
set-esm-loader-flaky
branch
from
6d5dd56 to
2c27f25
Compare
October 18, 2023 01:00
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Sorry, something went wrong.
panva
approved these changes
Oct 18, 2023
Copy link
Copy Markdown
Member
|
cc: @nodejs/loaders |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50226 ✔ Done loading data for nodejs/node/pull/50226 ----------------------------------- PR info ------------------------------------ Title test: set `test-esm-loader-resolve-type` as flaky (#50226) Author Yagiz Nizipli (@anonrig) Branch anonrig:set-esm-loader-flaky -> nodejs:main Labels test, flaky-test, esm, fast-track, author ready, needs-ci Commits 1 - test: set `test-esm-loader-resolve-type` as flaky Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/50226 Refs: https://github.com/nodejs/node/issues/50040 Reviewed-By: Filip Skokan ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50226 Refs: https://github.com/nodejs/node/issues/50040 Reviewed-By: Filip Skokan -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 18 Oct 2023 00:59:02 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/50226#pullrequestreview-1685682568 ℹ This PR is being fast-tracked ✘ This PR needs to wait 145 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-18T14:51:15Z: https://ci.nodejs.org/job/node-test-pull-request/54950/ - Querying data for job/node-test-pull-request/54950/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6567812182 |
Sorry, something went wrong.
GeoffreyBooth
approved these changes
Oct 18, 2023
25 tasks
Copy link
Copy Markdown
Contributor
|
We'll need to revert that once #50273 has landed |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Can we revert it in the deflake pull request? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #50040