FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: deflake `test-esm-loader-resolve-type` by aduh95 · Pull Request #50273 · nodejs/node · GitHub

/ node Public

test: deflake test-esm-loader-resolve-type - #50273

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-esm-loader-resolve-type
Oct 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: deflake test-esm-loader-resolve-type#50273
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-esm-loader-resolve-type

Conversation

aduh95 commented Oct 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sending messages cross threads is inherently flaky as there's no guarantee the other thread will receive the message in a timely manner. Thankfully JS exposes the SharedArrayBuffer+Atomics API for this exact use case.

Fixes: #50040

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 19, 2023
Uzlopak approved these changes Oct 19, 2023
View reviewed changes

Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Interesting. LGTM

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55000/

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55011/

aduh95 mentioned this pull request Oct 19, 2023
Merged
github-actions Bot mentioned this pull request Oct 20, 2023
Open
20 tasks
mhdawson approved these changes Oct 20, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55048/

mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 20, 2023

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55056/

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55061/

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55065/

github-actions Bot mentioned this pull request Oct 21, 2023
Open
24 tasks
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 21, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
nodejs-github-bot merged commit c38ba67 into nodejs:main Oct 21, 2023

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in c38ba67

aduh95 deleted the test-esm-loader-resolve-type branch October 21, 2023 10:03
aduh95 mentioned this pull request Oct 21, 2023
Merged
This was referenced Oct 22, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
test: deflake test-esm-loader-resolve-type
19d3ce2 
PR-URL: #50273
Fixes: #50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Oct 23, 2023
Merged
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 11, 2023
test: deflake test-esm-loader-resolve-type
b55fcd7 
PR-URL: #50273
Fixes: #50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: deflake test-esm-loader-resolve-type
52901a7 
PR-URL: nodejs#50273
Fixes: nodejs#50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 23, 2023
test: deflake test-esm-loader-resolve-type
d5cc5d7 
PR-URL: #50273
Backport-PR-URL: #50669
Fixes: #50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: deflake test-esm-loader-resolve-type
7593586 
PR-URL: nodejs/node#50273
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: deflake test-esm-loader-resolve-type
52a27e2 
PR-URL: nodejs/node#50273
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
marco-ippolito marco-ippolito approved these changes
+3 more reviewers
targos targos approved these changes
Uzlopak Uzlopak approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky: test-esm-loader-resolve-type

7 participants

Back | FazBrowse Home | New Git URL