FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: remove workaround for `esm` package by anonrig · Pull Request #50907 · nodejs/node · GitHub

/ node Public

fs: remove workaround for esm package - #50907

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-workaround
Nov 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

fs: remove workaround for esm package#50907
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-workaround

Conversation

anonrig commented Nov 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Removes a TODO left by @ronag

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 25, 2023
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2023

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55921/

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55922/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2023
nodejs-github-bot merged commit 95b1989 into nodejs:main Nov 27, 2023

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 95b1989

targos pushed a commit that referenced this pull request Dec 4, 2023
fs: remove workaround for esm package
c1ee506 
PR-URL: #50907
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
This was referenced Dec 4, 2023
Merged
Closed

ronag commented Dec 7, 2023

Copy link
Copy Markdown
Member

A little unsure why this was applied before standard-things/esm#821 was resolved?

targos commented Feb 15, 2024

Copy link
Copy Markdown
Member

@ronag The esm module was archived. It will never be resolved.

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
Revert "fs: remove workaround for esm package"
f130a33 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue #51081

Backport-PR-URL: #51390
PR-URL: #50907
Fixes: #51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
ronag ronag approved these changes
MoLow MoLow approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL