FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v21.x] Revert "fs: remove workaround for `esm` package" by jeremymeng · Pull Request #51390 · nodejs/node · GitHub

/ node Public

[v21.x] Revert "fs: remove workaround for esm package" - #51390

Closed
jeremymeng wants to merge 1 commit into
nodejs:v21.x-stagingfrom
jeremymeng:bring-back-workaround-for-esm
ConversationCommits (1)ChecksFiles changed
Closed

[v21.x] Revert "fs: remove workaround for esm package"#51390
jeremymeng wants to merge 1 commit into
nodejs:v21.x-stagingfrom
jeremymeng:bring-back-workaround-for-esm

Conversation

jeremymeng commented Jan 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Fixes: #51081

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v21.x labels Jan 6, 2024

jeremymeng commented Jan 6, 2024

Copy link
Copy Markdown
Author

per discussion at #51356 (comment), targeting v21.x-staging

H4ad previously approved these changes Jan 10, 2024
View reviewed changes
H4ad dismissed their stale review January 10, 2024 21:58

Before approving, do we have some docs about reverting changes? Should we actually revert or create a new commit with the change?

H4ad requested review from RafaelGSS, aduh95 and mcollina January 10, 2024 21:59
H4ad approved these changes Jan 10, 2024
View reviewed changes

H4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

According to reverting commits docs, you only need to include Fixes: #PR in the PR message, can you update that?

H4ad added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024

nodejs-github-bot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56739/

aduh95 changed the title Revert "fs: remove workaround for esm package" [v21.x] Revert "fs: remove workaround for esm package" Jan 10, 2024

aduh95 commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

you only need to include Fixes: #PR in the PR message, can you update that?

No need to modify the commit message for that, you can edit the PR description and it will be picked up by ncu and added to the commit message upon landing. But not sure if we use the same process for landing PRs on staging branches.

RafaelGSS reviewed Jan 10, 2024
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why revert it only to v21.x but not main?

jeremymeng commented Jan 10, 2024

Copy link
Copy Markdown
Author

According to reverting commits docs, you only need to include Fixes: #PR in the PR message, can you update that?

Done

targos commented Feb 15, 2024

Copy link
Copy Markdown
Member

@RafaelGSS Because the esm package is archived and will never be fixed.

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57099/

targos force-pushed the bring-back-workaround-for-esm branch from 1c408b0 to a8d2d56 Compare February 20, 2024 07:56

targos commented Feb 20, 2024

Copy link
Copy Markdown
Member

Rebased to include jeremymeng@83f581d

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57192/

targos mentioned this pull request Feb 20, 2024
Closed

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57263/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57264/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57275/

marco-ippolito commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@jeremymeng rebased

marco-ippolito force-pushed the bring-back-workaround-for-esm branch from a8d2d56 to 3301a7d Compare February 26, 2024 13:51
Revert "fs: remove workaround for esm package"
4368d29 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue nodejs#51081
marco-ippolito force-pushed the bring-back-workaround-for-esm branch from 3301a7d to 4368d29 Compare February 27, 2024 11:21
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57458/

nodejs-github-bot commented Feb 27, 2024 •
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

🟢 GREEN CI: https://ci.nodejs.org/job/node-test-pull-request/57460/

marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
Revert "fs: remove workaround for esm package"
5aacd62 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue #51081

Backport-PR-URL: #51390
PR-URL: #51390
Fixes: #51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
marco-ippolito added backported-to-v21.x and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 27, 2024
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
Revert "fs: remove workaround for esm package"
f130a33 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue #51081

Backport-PR-URL: #51390
PR-URL: #50907
Fixes: #51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
ddribin mentioned this pull request Feb 29, 2024
Closed

marco-ippolito commented Mar 1, 2024

Copy link
Copy Markdown
Member

Landed in f130a33

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

H4ad H4ad approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes
mcollina Awaiting requested review from mcollina
aduh95 Awaiting requested review from aduh95
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL