FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: disable abort exceptions for module loading by anonrig · Pull Request #50987 · nodejs/node · GitHub

/ node Public

src: disable abort exceptions for module loading - #50987

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-contains-module-syntax
Dec 3, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: disable abort exceptions for module loading#50987
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-contains-module-syntax

Conversation

anonrig commented Dec 1, 2023

Copy link
Copy Markdown
Member

Fixes #50878.

Thanks @joyeecheung for the tip on temporarily disable abort_on_uncaught_exception while checking for modules.

cc @nodejs/loaders @nodejs/cpp-reviewers

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Dec 1, 2023
anonrig force-pushed the fix-contains-module-syntax branch 4 times, most recently from 7e81ca2 to 080b5c9 Compare December 1, 2023 01:25
GeoffreyBooth approved these changes Dec 1, 2023
View reviewed changes
Comment thread test/es-module/test-esm-detect-ambiguous.mjs Outdated
anonrig force-pushed the fix-contains-module-syntax branch from 080b5c9 to 43020e5 Compare December 1, 2023 01:28
anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 1, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56025/

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56027/

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56028/

joyeecheung reviewed Dec 1, 2023
View reviewed changes
Comment thread src/node_contextify.cc Outdated

joyeecheung commented Dec 1, 2023

Copy link
Copy Markdown
Member

The commit message is not quite accurate, it should be something like "disable uncaught exception abortion for ESM syntax detection"

aduh95 reviewed Dec 1, 2023
View reviewed changes
Comment thread test/es-module/test-esm-detect-ambiguous.mjs Outdated
Comment thread test/es-module/test-esm-detect-ambiguous.mjs Outdated
anonrig force-pushed the fix-contains-module-syntax branch from 43020e5 to ae34969 Compare December 2, 2023 22:49
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2023

nodejs-github-bot commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56048/

targos suggested changes Dec 3, 2023
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I want at least an answer on #50987 (comment)

anonrig force-pushed the fix-contains-module-syntax branch from ae34969 to 86d275a Compare December 3, 2023 15:04

anonrig commented Dec 3, 2023

Copy link
Copy Markdown
Member Author

I want at least an answer on #50987 (comment)

Sorry @targos. I missed your comment! It seems your suggestion is better. I applied the proposed changes.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023

nodejs-github-bot commented Dec 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56051/

nodejs-github-bot commented Dec 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56058/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2023
nodejs-github-bot merged commit 951d00d into nodejs:main Dec 3, 2023

nodejs-github-bot commented Dec 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 951d00d

targos pushed a commit that referenced this pull request Dec 4, 2023
src: disable uncaught exception abortion for ESM syntax detection
709ac47 
PR-URL: #50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request Dec 4, 2023
Merged
Mateusz-Kopec mentioned this pull request Mar 6, 2024
Closed
Mateusz-Kopec pushed a commit to Mateusz-Kopec/node that referenced this pull request Mar 6, 2024
src: disable uncaught exception abortion for ESM syntax detection
96f067c 
PR-URL: nodejs#50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

Backport-PR-URL: nodejs#51989
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: disable uncaught exception abortion for ESM syntax detection
362135a 
PR-URL: #50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung left review comments
GeoffreyBooth GeoffreyBooth approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] --abort-on-uncaught-exception causes containsModuleSyntax to improperly throw Uncaught SyntaxError: Cannot use import statement outside a module

7 participants

Back | FazBrowse Home | New Git URL