FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x backport] src: disable uncaught exception abortion for ESM syntax detection by Mateusz-Kopec · Pull Request #51989 · nodejs/node · GitHub

/ node Public

[v20.x backport] src: disable uncaught exception abortion for ESM syntax detection - #51989

Closed
Mateusz-Kopec wants to merge 1 commit into
nodejs:v20.x-stagingfrom
Mateusz-Kopec:backport-50987-to-v20.x
ConversationCommits (1)ChecksFiles changed
Closed

[v20.x backport] src: disable uncaught exception abortion for ESM syntax detection#51989
Mateusz-Kopec wants to merge 1 commit into
nodejs:v20.x-stagingfrom
Mateusz-Kopec:backport-50987-to-v20.x

Conversation

Mateusz-Kopec commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Refs: #50987
Fixes: #50878

I confirmed that Wrapping a require of an ES module while using --abort-on-uncaught-exception fails without the fix

PS. I read through Backporting release lines and Contributing and I'm still not sure what should I do to get the fix backported.

a) Is it still "baking", is the process automated so should I just wait a bit more?
b) Should I just add some label backport-requested-vN.x and because there are no conflicts it will be automatically backported? I guess it's not possible.
c) Was it decided that fix shouldn't land in LTS?

Please let me know if I should close this PR and request it some other way. :)

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v20.x vm Issues and PRs related to the vm subsystem. labels Mar 6, 2024
src: disable uncaught exception abortion for ESM syntax detection
96f067c 
PR-URL: nodejs#50987
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

Backport-PR-URL: nodejs#51989
Mateusz-Kopec force-pushed the backport-50987-to-v20.x branch from 7955fb6 to 96f067c Compare March 6, 2024 16:35

anonrig commented Mar 6, 2024

Copy link
Copy Markdown
Member

cc @nodejs/releasers

targos commented Mar 6, 2024

Copy link
Copy Markdown
Member

Is it a clean cherry-pick? If that's the case, a backport PR shouldn't be necessary. We use lts-watch- label to bring PRs to the attention of releasers.

Mateusz-Kopec commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Is it a clean cherry-pick? If that's the case, a backport PR shouldn't be necessary. We use lts-watch- label to bring PRs to the attention of releasers.

It is clean cherry-pick, is there a way for me to add label? I assume there's some permission that prevents label spam from people that are not maintainers.
Or would the correct action be to just comment in the mentioned PR?

anonrig commented Mar 6, 2024

Copy link
Copy Markdown
Member

I've added the labels.

Mateusz-Kopec commented Mar 6, 2024

Copy link
Copy Markdown
Author

I've added the labels.

Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL