lib: fix recursive watch on Linux - #51049
Closed
rubenpad wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
rubenpad
force-pushed
the
lib-fix-recursive-watch-on-linux
branch
from
501f1df to
2446ef6
Compare
December 4, 2023 23:45
anonrig
approved these changes
Dec 5, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
there seem te be related test failures:
https://ci.nodejs.org/job/node-test-commit-osx-arm/14863/
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48437
Any changes that happen before the watch is set up are lost because the traverse call is asynchronous. I get the tests to pass changing the traverse call by this.#watchFile to watch the folder before any changes and then calling this.#watchFolder to traverse the folder's content and watch it.
Also noticed the timeout calls in the tests. I removed them because I think they're highlighting the issue.