FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: remove race condition for recursive watch on Linux by mcollina · Pull Request #51406 · nodejs/node · GitHub

/ node Public

fs: remove race condition for recursive watch on Linux - #51406

Merged
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
mcollina:fix-recursive
Jan 25, 2024
ConversationCommits (8)ChecksFiles changed
Merged

fs: remove race condition for recursive watch on Linux#51406
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
mcollina:fix-recursive

Conversation

mcollina commented Jan 8, 2024

Copy link
Copy Markdown
Member

Fixes #48437

fs: remove race condition for recursive watch on Linux
99d7b73 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 8, 2024

mcollina commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

Supersedes #51049 with a complete fix.

anonrig approved these changes Jan 8, 2024
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

fixup
0101f44 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jan 8, 2024
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2024

nodejs-github-bot commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56714/

richardlau reviewed Jan 8, 2024
View reviewed changes
Comment thread test/parallel/test-fs-recursive-sync-write.js Outdated
fixup
4586010 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024
fixup
ff16eca 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

anonrig commented Jan 11, 2024

Copy link
Copy Markdown
Member

Linter is failing @mcollina

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56750/

update old tests
63d8245 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
major rewrite of Linux recursive watch
faf947d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2024

nodejs-github-bot commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56844/

fixup
00ce833 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2024

nodejs-github-bot commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56846/

fixup
607bf16 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024

nodejs-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56883/

nodejs-github-bot commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56912/

mcollina commented Jan 25, 2024

Copy link
Copy Markdown
Member Author

@anonrig @richardlau PTAL, this is good to land.

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2024
nodejs-github-bot merged commit 2791e83 into nodejs:main Jan 25, 2024

nodejs-github-bot commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2791e83

mcollina mentioned this pull request Jan 26, 2024
Closed
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
fs: remove race condition for recursive watch on Linux
3cec9d8 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#51406
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow mentioned this pull request Feb 13, 2024
Closed
targos pushed a commit that referenced this pull request Feb 15, 2024
fs: remove race condition for recursive watch on Linux
15a7f21 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #51406
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
fs: remove race condition for recursive watch on Linux
bbd1351 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #51406
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau mentioned this pull request Mar 25, 2024
Merged
kylo5aby mentioned this pull request Mar 26, 2024
Closed
benmccann mentioned this pull request May 20, 2024
Merged
This was referenced Aug 2, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
richardlau richardlau left review comments
MoLow MoLow approved these changes
marco-ippolito marco-ippolito approved these changes
atlowChemi Awaiting requested review from atlowChemi
cjihrig Awaiting requested review from cjihrig

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node 20 recursive file watching is misbehaving on Linux

6 participants

Back | FazBrowse Home | New Git URL