benchmark: remove dependency on unshipped tools - #51146
Closed
AdamMajer wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
An alternative to using npx is to reduce the number of executables run here to 2 |
Sorry, something went wrong.
AdamMajer
force-pushed
the
cli-benchmark-fix
branch
from
800a804 to
493be23
Compare
December 13, 2023 13:49
lpinca
approved these changes
Dec 13, 2023
Copy link
Copy Markdown
Member
|
cc @nodejs/build |
Sorry, something went wrong.
joyeecheung
reviewed
Dec 14, 2023
Comment thread
benchmark/misc/startup-cli-version.js
Outdated
tools/node_modules is removed from the tarball so it should not be used as part of unit tests or benchmarks. Fixes: nodejs#51145 Refs: nodejs#50684
AdamMajer
force-pushed
the
cli-benchmark-fix
branch
from
493be23 to
35403d7
Compare
December 15, 2023 14:04
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Dec 25, 2023
Merged
AdamMajer
added a commit
to AdamMajer/node
that referenced
this pull request
Feb 14, 2024
In previous version of this fix, I've simply added a check if the tested tool is available or not. Unfortuntelly, this fails when only the first tool is to be run as part of the test-benchmark-misc, and it doesn't exist. benchmark/test-benchmark-misc ... AssertionError [ERR_ASSERTION]: benchmark file not running exactly one configuration in test: ... misc/startup-cli-version.js ... One solution is to check if the cli tool is actually available before using it in a benchmark Refs: nodejs#51146
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#51746 Refs: nodejs#51146 Refs: nodejs#50684 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/node_modules is removed from the tarball so it should not be used as part of unit tests or benchmarks.
Fixes: #51145