benchmark: move non-present deps down the list - #51746
Merged
aduh95 merged 1 commit intoMay 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AdamMajer
force-pushed
the
benchmark-fixes
branch
2 times, most recently
from
396f5e4 to
893ac74
Compare
February 13, 2024 12:44
richardlau
approved these changes
Feb 13, 2024
joyeecheung
reviewed
Feb 13, 2024
Comment thread
benchmark/misc/startup-cli-version.js
Outdated
In previous version of this fix, I've simply added a check if the tested tool is available or not. Unfortuntelly, this fails when only the first tool is to be run as part of the test-benchmark-misc, and it doesn't exist. benchmark/test-benchmark-misc ... AssertionError [ERR_ASSERTION]: benchmark file not running exactly one configuration in test: ... misc/startup-cli-version.js ... One solution is to check if the cli tool is actually available before using it in a benchmark Refs: nodejs#51146
AdamMajer
force-pushed
the
benchmark-fixes
branch
from
893ac74 to
91bba09
Compare
February 14, 2024 12:36
lpinca
approved these changes
Feb 14, 2024
marco-ippolito
approved these changes
Feb 15, 2024
joyeecheung
approved these changes
Feb 29, 2024
marco-ippolito
approved these changes
Feb 29, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51746 ✔ Done loading data for nodejs/node/pull/51746 ----------------------------------- PR info ------------------------------------ Title benchmark: move non-present deps down the list (#51746) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch AdamMajer:benchmark-fixes -> nodejs:main Labels benchmark Commits 1 - benchmark: move non-present deps down the list Committers 1 - Adam Majer PR-URL: https://github.com/nodejs/node/pull/51746 Fixes: https://github.com/nodejs/node/pull/51146 Refs: https://github.com/nodejs/node/pull/50684 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51746 Fixes: https://github.com/nodejs/node/pull/51146 Refs: https://github.com/nodejs/node/pull/50684 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 13 Feb 2024 12:31:27 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51746#pullrequestreview-1877961858 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51746#pullrequestreview-1881265306 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51746#pullrequestreview-1909418797 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51746#pullrequestreview-1909400852 ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8113019460 |
Sorry, something went wrong.
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#51746 Refs: nodejs#51146 Refs: nodejs#50684 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous version of this fix, I've simply added a check if the tested tool is available or not. Unfortuntelly, this fails when only the first tool is to be run as part of the test-benchmark-misc, and it doesn't exist.
The solution is to move the tool that is not present in a tarball down the list.
Fixes: #51146
Refs: #50684