FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix dns.lookup and dnsPromises.lookup description by duncanchiu409 · Pull Request #51517 · nodejs/node · GitHub

/ node Public

doc: fix dns.lookup and dnsPromises.lookup description - #51517

Merged
aduh95 merged 10 commits into
nodejs:mainfrom
duncanchiu409:my-branch
Jan 30, 2024
ConversationCommits (10)ChecksFiles changed
Merged

doc: fix dns.lookup and dnsPromises.lookup description#51517
aduh95 merged 10 commits into
nodejs:mainfrom
duncanchiu409:my-branch

Conversation

duncanchiu409 commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

Fixes: #51482
Continue on: #51483

nodejs-github-bot commented Jan 18, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2024
ShogunPanda requested changes Jan 19, 2024
View reviewed changes
Comment thread doc/api/dns.md Outdated
Comment thread doc/api/dns.md Outdated
Comment thread doc/api/dns.md Outdated
duncanchiu409 and others added 3 commits January 26, 2024 14:18
Update doc/api/dns.md
fa94817 
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Update doc/api/dns.md
6c1e119 
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Update doc/api/dns.md
03da199 
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda requested changes Jan 26, 2024
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor things are pointed out in #51517 (comment).
After that, it LGTM!

Comment thread doc/api/dns.md Outdated
Comment thread doc/api/dns.md Outdated
mcollina approved these changes Jan 26, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

duncanchiu409 and others added 2 commits January 27, 2024 15:28
Update doc/api/dns.md
78af021 
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Update doc/api/dns.md
a1951a5 
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
lpinca reviewed Jan 27, 2024
View reviewed changes
Comment thread doc/api/dns.md Outdated
Update dns.md
6eeae0f 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

aduh95 commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Linter is failing

duncanchiu409 commented Jan 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Is there something similar to lint --fix ? Is it make format-md?

aduh95 previously approved these changes Jan 30, 2024
View reviewed changes
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 30, 2024
aduh95 dismissed their stale review January 30, 2024 01:18

Wrong button

aduh95 merged commit 0f461aa into nodejs:main Jan 30, 2024

aduh95 commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Landed in 0f461aa

duncanchiu409 commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

Thanks to all for the work & take attention to my PR.

domdomegg commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

This isn't correct, as dicussed in #51482 and #51483 (comment)

We either need to make sure node actually has this behaviour, or revert this docs commit as this is taking it from ambigious to wrong :/

domdomegg mentioned this pull request Feb 3, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
doc: fix dns.lookup and dnsPromises.lookup description
126a6c3 
PR-URL: nodejs#51517
Fixes: nodejs#51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
doc: fix dns.lookup and dnsPromises.lookup description
8c0a257 
PR-URL: #51517
Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
doc: fix dns.lookup and dnsPromises.lookup description
1dae187 
PR-URL: #51517
Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca left review comments
mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
aduh95 aduh95 left review comments

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading

7 participants

Back | FazBrowse Home | New Git URL