FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix dns.lookup family `0` and `all` description by domdomegg · Pull Request #51653 · nodejs/node · GitHub

/ node Public

doc: fix dns.lookup family 0 and all description - #51653

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
domdomegg:fix-51482
May 11, 2024
Merged

doc: fix dns.lookup family 0 and all description#51653
aduh95 merged 3 commits into
nodejs:mainfrom
domdomegg:fix-51482

Conversation

domdomegg commented Feb 3, 2024
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Fixes: #51482

Also see #51483, #51517

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Feb 3, 2024
domdomegg changed the title doc: fix dns.lookup family 0 and all description doc: fix dns.lookup family 0 and all description Feb 3, 2024
aduh95 requested a review from ShogunPanda February 3, 2024 17:10

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 11, 2024
aduh95 merged commit 6e07a76 into nodejs:main May 11, 2024

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Landed in 6e07a76

targos pushed a commit that referenced this pull request May 12, 2024
PR-URL: #51653
Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #51653
Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#51653
Fixes: nodejs#51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading

4 participants


Back | FazBrowse Home | New Git URL