FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update c-ares to 1.26.0 for Android by MeowShe · Pull Request #51646 · nodejs/node · GitHub

/ node Public

deps: update c-ares to 1.26.0 for Android - #51646

Merged
lpinca merged 1 commit into
nodejs:actions/tools-update-c-aresfrom
MeowShe:actions/tools-update-c-ares
Feb 2, 2024
Merged

deps: update c-ares to 1.26.0 for Android#51646
lpinca merged 1 commit into
nodejs:actions/tools-update-c-aresfrom
MeowShe:actions/tools-update-c-ares

Conversation

MeowShe commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Related PR: #51582

Update ares_config.h for Android with c-ares version 1.26.0.

NOTICE: This is only for arch arm64-v8a.

Built with Android NDK 26.1.10909125, c-ares HEAD.

Related PR: nodejs#51582

Update ares_config.h for Android with c-ares version 1.26.0.

NOTICE: This is only for arch arm64-v8a.

Built with `Android NDK 26.1.10909125`, c-ares `HEAD`.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 2, 2024

MeowShe commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

cc: @lpinca I just opened a new PR.

lpinca commented Feb 2, 2024

Copy link
Copy Markdown
Member

Is it possible to use Autotools to create ares_config.h? I'm asking because it would make the diff smaller.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

lpinca merged commit 433b11b into nodejs:actions/tools-update-c-ares Feb 2, 2024
MeowShe deleted the actions/tools-update-c-ares branch February 3, 2024 01:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL