FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: remove `librt` library dependency for Android compatibility by MeowShe · Pull Request #51632 · nodejs/node · GitHub

/ node Public

build: remove librt library dependency for Android compatibility - #51632

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MeowShe:android-v8_gypfiles
Feb 25, 2024
ConversationCommits (1)ChecksFiles changed
Merged

build: remove librt library dependency for Android compatibility#51632
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MeowShe:android-v8_gypfiles

Conversation

MeowShe commented Feb 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

On Android, unlike Linux, there are no separate libpthread or librt libraries. That functionality is included directly in libc, which does not need to be explicitly linked against. (Native APIs | Android NDK)

Fix: #50184

Remove librt library dependency when building Node.js for Android, as it does not exist on Android.

Related to PR #51646, as part of a series of build fixes for Android.

nodejs-github-bot commented Feb 1, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 1, 2024
MeowShe changed the title build: remove librt lib link for Android compatibility build: remove librt library dependency for Android compatibility Feb 1, 2024
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2024

nodejs-github-bot commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57038/

nodejs-github-bot commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5798/

nodejs-github-bot commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5798/

nodejs-github-bot commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5798/

MeowShe mentioned this pull request Feb 4, 2024
Closed

MeowShe commented Feb 5, 2024

Copy link
Copy Markdown
Contributor Author

Could we re-request CI again?

MeowShe closed this Feb 10, 2024
MeowShe reopened this Feb 10, 2024

lpinca commented Feb 12, 2024

Copy link
Copy Markdown
Member

Could we re-request CI again?

It is under security embargo.

MeowShe mentioned this pull request Feb 13, 2024
Closed

MeowShe commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

Could we re-request CI again?

It is under security embargo.

Anything should I do for that?

lpinca commented Feb 14, 2024

Copy link
Copy Markdown
Member

No, thank you.

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57092/

lpinca mentioned this pull request Feb 24, 2024
Closed

nodejs-github-bot commented Feb 24, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57391/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2024
nodejs-github-bot merged commit 56ced19 into nodejs:main Feb 25, 2024

nodejs-github-bot commented Feb 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 56ced19

MeowShe deleted the android-v8_gypfiles branch February 26, 2024 04:19
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
build: remove librt libs link for Android compatibility
6093759 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
build: remove librt libs link for Android compatibility
c9ada53 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
build: remove librt libs link for Android compatibility
4118174 
PR-URL: #51632
Fixes: #50184
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v8: "ld.lld: error: unable to find library -lrt" when building for android aarch64

4 participants

Back | FazBrowse Home | New Git URL