Review requested:

• @nodejs/actions

All other files use the extension .yml as far as I can tell. I'd suggest renaming to build-androi.yml for consistency.

You're right, it's a mistake.

• Is there any way to try and run it before merging?
• Is it going to block commit queue when it fails?

• Is there any way to try and run it before merging?

• Is it going to block commit queue when it fails?

1. We are waiting for another PR merge regarding Android build fixes. (build: remove librt library dependency for Android compatibility #51632)

2. This is an experimental feat., it shouldn't block commit queue even if fails.

This is an experimental feat., it shouldn't block commit queue even if fails.

I know it shouldn't, but I'm afraid it will (it runs on pull_request event).

Is it going to block commit queue when it fails?

GitHub unfortunately still does not support allowed failures (see actions/runner#2347), but perhaps one could use continue-on-error somehow?

We can use continue-on-error. It will make the run always green.
I'm still sceptical about having feedback on all pull requests for a very experimental target.
A new actions run will use a worker from the pool and add a pending check to the pull request while it runs.

@tniessen @targos continue-on-error has been used already(dea50f6).

I'm still sceptical about having feedback on all pull requests for a very experimental target.

A new actions run will use a worker from the pool and add a pending check to the pull request while it runs.

The main purpose of this pull request is to advance the official support of Node.js for the Android platform. Once the goal is achieved and it becomes stable, this check should become mandatory.

I'm still sceptical about having feedback on all pull requests for a very experimental target.

Perhaps in the short term having it be a path-based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs.

Maybe label is a better idea? We label PRs when if it fit to run Android build test.

path based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs.

I guess there doesn't seem to be a clear definition of paths, we don't know what paths are available to run Android build tests in particular.

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.