FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: remove `patch` for Android build by MeowShe · Pull Request #51660 · nodejs/node · GitHub

/ node Public

build: remove patch for Android build - #51660

Closed
MeowShe wants to merge 1 commit into
nodejs:mainfrom
MeowShe:android-fixes
Closed

build: remove patch for Android build#51660
MeowShe wants to merge 1 commit into
nodejs:mainfrom
MeowShe:android-fixes

Conversation

MeowShe commented Feb 4, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Patch to src/trap-handler/trap-handler.h is no longer needed now in Android building.

Tested on Docker with image ubuntu:latest with eca4b1a (HEAD), android-ndk-r26b-linux.

Related to PR #51632, as part of a series of build fixes for Android.

MeowShe commented Feb 5, 2024

Copy link
Copy Markdown
Contributor Author

CC @richardlau

lpinca commented Feb 6, 2024

Copy link
Copy Markdown
Member

Wouldn't it be better to keep the patch support in android_configure.py and only remove the actual patch? We might need to apply another patch in the future, no?

MeowShe commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Wouldn't it be better to keep the patch support in android_configure.py and only remove the actual patch? We might need to apply another patch in the future, no?

I understand your point, however, the patch was initially intended as a compromise, and all issues that arise should be addressed at their source, rather than being temporarily mitigated through patches.

But again, I think it's going to take some time to transition, so let's keep the patch for now, and thank you for your input.

MeowShe closed this Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL