FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v21.x backport] deps: update undici to 6.6.2 by targos · Pull Request #51768 · nodejs/node · GitHub

/ node Public

[v21.x backport] deps: update undici to 6.6.2 - #51768

Closed
targos wants to merge 2 commits into
nodejs:v21.x-stagingfrom
targos:undici-backport-v21
Closed

[v21.x backport] deps: update undici to 6.6.2#51768
targos wants to merge 2 commits into
nodejs:v21.x-stagingfrom
targos:undici-backport-v21

Conversation

targos commented Feb 15, 2024

Copy link
Copy Markdown
Member

This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from main until
6.6.2, which also includes the security fix.

Reverts: 9d2ac2b
Includes:

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v21.x labels Feb 15, 2024
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos commented Feb 19, 2024

Copy link
Copy Markdown
Member Author

I'll wait for #51792 to rebase.

targos force-pushed the undici-backport-v21 branch from 376cc0e to c332fc0 Compare February 20, 2024 05:16

targos commented Feb 20, 2024

Copy link
Copy Markdown
Member Author

Rebased.

targos force-pushed the undici-backport-v21 branch from c332fc0 to 57c0422 Compare February 20, 2024 05:18
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@targos can you rebase, the CI should fine fine now

targos commented Feb 26, 2024

Copy link
Copy Markdown
Member Author

@marco-ippolito My branch is already up-to-date wrt. v21.x-staging

Copy link
Copy Markdown
Collaborator

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

This reverts commit 95b1989.

It appears that the workaround is still needed: issue nodejs#51081

Backport-PR-URL: nodejs#51390
PR-URL: nodejs#51390
Fixes: nodejs#51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from `main` until
6.6.2, which also includes the security fix.
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from `main` until
6.6.2, which also includes the security fix.

Backport-PR-URL: #51768
PR-URL: #51667
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Copy link
Copy Markdown
Member

Landed in 4ebb944

targos deleted the undici-backport-v21 branch March 1, 2024 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL