FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: eval a strict function by kthelgason · Pull Request #5250 · nodejs/node · GitHub

/ node Public

test: eval a strict function - #5250

Closed
kthelgason wants to merge 1 commit into
nodejs:masterfrom
kthelgason:regr-test-eval-strict
ConversationCommits (1)ChecksFiles changed
Closed

test: eval a strict function#5250
kthelgason wants to merge 1 commit into
nodejs:masterfrom
kthelgason:regr-test-eval-strict

Conversation

kthelgason commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

This PR adds a regression test for the bug mentioned in #2245 where when a strict function is evaled it would not capture it's context.

mscdex added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels Feb 15, 2016

Trott commented Feb 16, 2016

Copy link
Copy Markdown
Member

Test fails for me in 3.x and passes in 4.0.0 and up, which is consistent with it detecting the bug it is designed to test, so that's good. (EDIT: Have to comment out common.js when running with Node 3.x because Node 3.x doesn't have the necessary ES6-isms. That's not a criticism or anything. Just a note for anyone else trying to do the same verification.)

thefourtheye commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

@Trott may be because template strings were not available before 4.x?

Trott commented Feb 16, 2016

Copy link
Copy Markdown
Member

@thefourtheye Yeah, and maybe other stuff too. I think there's at least one arrow functions in there now, for example.

kthelgason commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

@Trott @thefourtheye should I rewrite this without template strings to make tests running this on old versions possible?

thefourtheye commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

@kthelgason Ya, since we claim that this fixes is a regression for a bug in 0.10, it would be better to be able to test it in that version. Can you please change that?

kthelgason force-pushed the regr-test-eval-strict branch from f7ea0f9 to cd5b3fc Compare February 16, 2016 14:09

kthelgason commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

@thefourtheye agreed. Fixed and pushed.

thefourtheye reviewed Feb 16, 2016
View reviewed changes
Comment thread test/parallel/test-regress-GH-2245.js
@@ -0,0 +1,28 @@
/* eslint-disable strict */

thefourtheye Feb 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why this is necessary?

kthelgason Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

in strict mode running this will fail as bar is undefined until the code has been evaled. If this line is not present the build will fail linting

targos Feb 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it would be better to disable the no-undef rule inline

kthelgason Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I could have been clearer above, the issue here is that this code is not valid in strict mode, since eval in strict mode does not introduce new variables into the surrounding scope. Therefore this file cannot have strict mode enabled, and hence this linter rule.

targos Feb 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh I see, my bad.

Trott commented Feb 16, 2016

Copy link
Copy Markdown
Member

This test ran perfectly fine in 3.x (with common.js removed) and there was no need to remove the template strings. Template strings are supported in 3.x.

The problem (which should not be "fixed") was in common.js and was probably the arrow function in that file.

If you want to restore the template string for better code hygiene, feel free.

kthelgason commented Feb 16, 2016

Copy link
Copy Markdown
Contributor Author

@Trott Ok, I still feel that there might be some value to being able to run the test under 0.10 to see the failure.

Trott commented Feb 16, 2016

Copy link
Copy Markdown
Member

@kthelgason Fair enough. I'm not opposed to the current format or anything.

kthelgason commented Mar 12, 2016

Copy link
Copy Markdown
Contributor Author

@Trott willing to land this or looking for more eyes on it first?

jasnell commented Mar 12, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye commented Mar 13, 2016

Copy link
Copy Markdown
Contributor

LGTM. CI Run: https://ci.nodejs.org/job/node-test-pull-request/1912/

jasnell pushed a commit that referenced this pull request Mar 14, 2016
test: eval a strict function
25eedf0 
PR-URL: #5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell commented Mar 14, 2016

Copy link
Copy Markdown
Member

Landed in 25eedf0

jasnell closed this Mar 14, 2016
kthelgason deleted the regr-test-eval-strict branch March 14, 2016 15:49
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
test: eval a strict function
1235176 
PR-URL: #5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas mentioned this pull request Mar 14, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
test: eval a strict function
cceae5a 
PR-URL: #5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
test: eval a strict function
8c682a3 
PR-URL: #5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
test: eval a strict function
666d369 
PR-URL: #5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell mentioned this pull request Apr 2, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL