v5.9.0 proposal by evanlucas · Pull Request #5702 · nodejs/node · GitHub

Aiming for Wednesday. Planning on cutting an rc hopefully tonight.

Notable changes:

contextify: Fixed a memory consumption issue related to heavy use of vm.createContext and vm.runInNewContext. (Ali Ijaz Sheikh)
(vee-eight-4.9) contextify: update deprecated SetWeak usage #5392
governance: The following members have been added as collaborators:
- Andreas Madsen (@AndreasMadsen)
- Benjamin Gruenbaum (@benjamingr)
- Claudio Rodriguez (@claudiorodriguez)
- Glen Keane (@thekemkid)
- Jeremy Whitlock (@whitlockjc)
- Matt Loring (@matthewloring)
- Phillip Johnsen (@phillipj)
lib: copy arguments object instead of leaking it (Nathan Woltman) lib: copy arguments object instead of leaking it #4361
src: allow combination of -i and -e cli flags (Rich Trott)
src: allow combination of -i and -e cli flags #5655
v8: backport fb4ccae from v8 upstream (Vladimir Krivosheev) v8 remote debug: export BreakEvent, BreakPoint and CompileEvent #4231
- breakout events from v8 to offer better support for external debuggers
zlib: add support for concatenated members (Kári Tristan Helgason) zlib: support concatenated archives #5120

Commits

[03b99bf8b9] - build: don't install github templates (Johan Bergström) #5612
[a7819da15a] - _Revert_ "build: run lint before tests" (Rich Trott) #5602
[5e9cac4333] - console: check that stderr is writable (Rich Trott) #5635
[0662fcf209] - contextify: cache sandbox and context in locals (Ali Ijaz Sheikh) #5392
[4f2c839d46] - contextify: replace deprecated SetWeak usage (Ali Ijaz Sheikh) #5392
[bfff07b4dd] - contextify: cleanup weak ref for sandbox (Ali Ijaz Sheikh) #5392
[93f60cdc54] - contextify: cleanup weak ref for global proxy (Ali Ijaz Sheikh) #5392
[29510aa4fd] - deps: update openssl config (Shigeki Ohtsu) #5630
[532d1bf9ce] - deps: sync deps/http_parser with nodejs/http_parser (James M Snell) #5600
[d5d64c327b] - doc: clarify commit message rules (Wyatt Preul) #5661
[8c4c84fe5b] - doc: add Testing WG (Rich Trott) #5461
[434af03825] - doc: Add note about use of JSON.stringify() (Mithun Patel) #5723
[62926d85bd] - doc: clarify type of first argument in zlib (Kirill Fomichev) #5685
[eb73574349] - doc: clarify when writable.write callback is called (Kevin Locke) #4810
[c579507034] - doc: fix typo in api/addons (Daijiro Wachi) #5678
[8e45c9d9ea] - doc: fix typo in api/dgram (Daijiro Wachi) #5678
[44a9b100c5] - doc: fix typo in api/fs (Daijiro Wachi) #5678
[b667573bcb] - doc: update fansworld-claudio username on README (Claudio Rodriguez) #5680
[9794abb5d1] - doc: add onboarding resources (Jeremiah Senkpiel) #3726
[31e39fbd7a] - doc: remove non-standard use of hyphens (Stefano Vozza)
[f3e9daa825] - doc: add clarification on birthtime in fs stat (Kári Tristan Helgason) #5479
[c379ec6522] - doc: move build instructions to a new document (Johan Bergström) #5634
[2a442b3dfc] - doc: update removeListener behaviour (Vaibhav) #5201
[f6ee0996e0] - doc: fix typo in child_process docs (Benjamin Gruenbaum) #5681
[dd12661173] - doc: include typo in 'unhandledRejection' example (Robert C Jensen) #5654
[f7aecd6e94] - doc: add thekemkid to collaborators (Glen Keane) #5667
[b81711acfb] - doc: add phillipj to collaborators (Phillip Johnsen) #5663
[a33f2486f0] - doc: add fansworld-claudio to collaborators (Claudio Rodriguez) #5668
[285d5e7ba6] - doc: add AndreasMadsen to collaborators (Andreas Madsen) #5666
[8e1f6706e3] - doc: add benjamingr to collaborator list (Benjamin Gruenbaum) #5664
[f7842cbb24] - doc: add whitlockjc to collaborators (Jeremy Whitlock) #5665
[dd6f4ec2e4] - doc: add mattloring to collaborators (Matt Loring) #5662
[9ebd559a55] - doc: fix markdown links (Steve Mao) #5641
[62d267e1ff] - doc: fix dns.resolveCname description typo (axvm) #5622
[9f8e2e2979] - doc: update release tweet template (Jeremiah Senkpiel) #5628
[4d6fe300fe] - doc: fix v5.8.0 changelog heading (Jeremiah Senkpiel) #5559
[4c1fdaeb2a] - docs: update link to iojs+release ci job (Myles Borins) #5632
[205bed0bec] - lib: copy arguments object instead of leaking it (Nathan Woltman) #4361
[b16f67a0b9] - net: make isIPv4 and isIPv6 more efficient (Vladimir Kurchatkin) #5478
[4ecd996baa] - (SEMVER-MINOR) src: allow combination of -i and -e cli flags (Rich Trott) #5655
[f225459496] - test: improve test-npm-install (Santiago Gimeno) #5613
[cceae5ae78] - test: eval a strict function (Kári Tristan Helgason) #5250
[9a44c8c337] - test: add batch of known issue tests (cjihrig) #5653
[1b7b1ed2c9] - timers: greatly improve code comments (Jeremiah Senkpiel) #4007
[769254b0ba] - timers: refactor timers (Jeremiah Senkpiel) #4007
[0b545fb3f8] - win,build: support Visual C++ Build Tools 2015 (João Reis) #5627
[ef774ff9a8] - (SEMVER-MINOR) zlib: add support for concatenated members (Kári Tristan Helgason) #5120

Notable changes: * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 PR-URL: #5702

Building RC 1: https://ci-release.nodejs.org/job/iojs+release/467/

Should this issue be part of 5.8.1 milestone?

Can you manually change

[4c4d9aeff1] - collaborator_guide: clarify commit message rules (Wyatt Preul) #5661

to

[4c4d9aeff1] - doc: clarify commit message rules (Wyatt Preul) #5661

In the commits list? :)

Also, a mention should probably be given about my timers change, if you want I'll write that point up.

@Fishrock123 yes, meant to ask what you wanted me to put for that. I'll change the commit in the list also.

Notable changes: * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 * **zlib**: add support for concatenated members (Kári Tristan Helgason) #5120 PR-URL: #5702

I've added the #5392 commits to v5.x, they should fix #3113.

@evanlucas can you rebase off v5.x please? Also, for the release PR on v5.x, just put the release commit in the PR with your CHANGELOG.md entries and src/node_version.h changes. All of the cherry-picking should just go straight in to v5.x (we get nightlies that way). I've put a bunch on v5.x, I did it the day before your PR but forgot to push (whoops) and now I've just done the contextify commits too.

Also, I believe this is actually 5.9.0 given the zlib commit, unless you want to back that one out and wait, up to you.

Ah sorry @rvagg. I'll get it updated tonight. Thanks for the check on the zlib commit. Does anyone oppose a v5.9.0?

Not opposed to it at all. There is another semver minor pull directly to v5.x that needs to land Would people be opposed to doing a slightly extended v5.9.0 rc, or is the idea to still release tomorrow?

Notable changes: * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 * **zlib**: add support for concatenated members (Kári Tristan Helgason) #5120 PR-URL: #5702

Notable changes: * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 * **src**: allow combination of -i and -e cli flags (Rich Trott) #5655 * **zlib**: add support for concatenated members (Kári Tristan Helgason) #5120 PR-URL: #5702

@ofrobots would you care to write up a sentence or so on the contextify changes? I'd say that is pretty notable.

@thealphanerd I'm indifferent. I was planning on releasing today (3/16), but can delay if needed.

writing the timers changelog bit...

timers: Internal Node.js timeouts now use the same logic path as those created with setTimeout() (Jeremiah Senkpiel) #4007
- This may cause a slightly different performance profile in some situations. So far, it has shown to be positive in most cases.

CI: https://ci.nodejs.org/job/node-test-pull-request/1941/

@evanlucas would you consider including 1231bf5 from #4231?

This is a backport of a fix to v8 that will not land on the v5.x version of v8

V8 review: https://codereview.chromium.org/1477233002/

V8 commit: https://chromium.googlesource.com/v8/v8/+/b201a7b93f35a3d66c319038d0f3419c7bd935cc

This commit is quite important for external debuggers

@evanlucas it has been landed in b6c355d on v5.x. So you should be able to simply rebase against v5.x to pull it in. (Don't forget to update the changelog after as all commit sha's will be different, I got bit by that one once 😢 )

v8: backport fb4ccae from v8 upstream (Vladimir Krivosheev) v8 remote debug: export BreakEvent, BreakPoint and CompileEvent #4231
- breakout events from v8 to offer better support for external debuggers

CI: https://ci.nodejs.org/job/node-test-pull-request/1942/

One more time

@evanlucas for the contextify changes you can use:

[These commits] fix a memory consumption issue related to heavy use of vm.createContext and vm.runInNewContext.

Thanks @ofrobots!

Notable changes: * **contextify**: Fixed a memory consumption issue related to heavy use of `vm.createContext` and `vm.runInNewContext`. (Ali Ijaz Sheikh) #5392 * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 * **src**: allow combination of -i and -e cli flags (Rich Trott) #5655 * **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231 - breakout events from v8 to offer better support for external debuggers * **zlib**: add support for concatenated members (Kári Tristan Helgason) #5120 PR-URL: #5702

PR-URL: #5702

Notable changes: * **contextify**: Fixed a memory consumption issue related to heavy use of `vm.createContext` and `vm.runInNewContext`. (Ali Ijaz Sheikh) #5392 * **governance**: The following members have been added as collaborators: - Andreas Madsen (@AndreasMadsen) - Benjamin Gruenbaum (@benjamingr) - Claudio Rodriguez (@claudiorodriguez) - Glen Keane (@thekemkid) - Jeremy Whitlock (@whitlockjc) - Matt Loring (@matthewloring) - Phillip Johnsen (@phillipj) * **lib**: copy arguments object instead of leaking it (Nathan Woltman) #4361 * **src**: allow combination of -i and -e cli flags (Rich Trott) #5655 * **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231 - breakout events from v8 to offer better support for external debuggers * **zlib**: add support for concatenated members (Kári Tristan Helgason) #5120 PR-URL: #5702

Nice work @evanlucas!

evanlucas added the meta Issues and PRs related to the general management of the project. label Mar 14, 2016

evanlucas mentioned this pull request Mar 14, 2016

Release proposal: v5.8.1 #5698

Closed

evanlucas force-pushed the v5.8.1-proposal branch from d83884b to 89dbfd9 Compare March 14, 2016 19:17

evanlucas force-pushed the v5.8.1-proposal branch from 89dbfd9 to cd11158 Compare March 14, 2016 19:19

Fishrock123 added this to the 5.8.1 milestone Mar 15, 2016

evanlucas force-pushed the v5.8.1-proposal branch from cd11158 to b94cacf Compare March 15, 2016 22:42

evanlucas force-pushed the v5.8.1-proposal branch from b94cacf to da46edb Compare March 16, 2016 10:38

evanlucas force-pushed the v5.8.1-proposal branch from da46edb to a08ac52 Compare March 16, 2016 10:42

evanlucas changed the title V5.8.1 proposal V5.9.0 proposal Mar 16, 2016

evanlucas changed the title V5.9.0 proposal v5.9.0 proposal Mar 16, 2016

evanlucas force-pushed the v5.8.1-proposal branch from a08ac52 to 64863d4 Compare March 16, 2016 17:28

MylesBorins closed this Mar 16, 2016

MylesBorins reopened this Mar 16, 2016

evanlucas force-pushed the v5.8.1-proposal branch from 64863d4 to ba62083 Compare March 16, 2016 18:37

evanlucas force-pushed the v5.8.1-proposal branch from ba62083 to 32117b5 Compare March 16, 2016 19:16

evanlucas force-pushed the v5.8.1-proposal branch from 32117b5 to 79cb1a9 Compare March 16, 2016 19:57

evanlucas merged commit 79cb1a9 into v5.x Mar 16, 2016

evanlucas added a commit that referenced this pull request Mar 16, 2016

Working on v5.9.1

0cac777

PR-URL: #5702

This was referenced Mar 17, 2016

Node.js v5.9.0 nodejs/docker-node#123

Closed

Update to v5.9.0. See #123 nodejs/docker-node#124

Merged

Update to Node.js v5.9.0 docker-library/official-images#1550

Merged

rvagg deleted the v5.8.1-proposal branch March 17, 2016 02:07

jedwards1211 mentioned this pull request May 21, 2021

Revisiting: fix for loading module twice with different case on case insensitive FSes #38752

Closed

v5.9.0 proposal by evanlucas · Pull Request #5702 · nodejs/node · GitHub

Uh oh!

Uh oh!

v5.9.0 proposal - #5702

v5.9.0 proposal#5702evanlucas merged 1 commit intov5.xnodejs/node:v5.xfrom v5.8.1-proposalnodejs/node:v5.8.1-proposalCopy head branch name to clipboard

Conversation

evanlucas commented Mar 14, 2016

Notable changes:

Commits

Uh oh!

evanlucas commented Mar 14, 2016

Uh oh!

imyller commented Mar 15, 2016

Uh oh!

Fishrock123 commented Mar 15, 2016

Uh oh!

Fishrock123 commented Mar 15, 2016

Uh oh!

evanlucas commented Mar 15, 2016

Uh oh!

rvagg commented Mar 16, 2016

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

MylesBorins commented Mar 16, 2016 via email

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

Fishrock123 commented Mar 16, 2016

Uh oh!

Fishrock123 commented Mar 16, 2016

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

MylesBorins commented Mar 16, 2016

Uh oh!

MylesBorins commented Mar 16, 2016

Uh oh!

MylesBorins commented Mar 16, 2016

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

ofrobots commented Mar 16, 2016

Uh oh!

evanlucas commented Mar 16, 2016

Uh oh!

rvagg commented Mar 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

v5.9.0 proposal#5702
evanlucas merged 1 commit into
v5.xfrom
v5.8.1-proposal