FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add AndreasMadsen to collaborators by AndreasMadsen · Pull Request #5666 · nodejs/node · GitHub

/ node Public

doc: add AndreasMadsen to collaborators - #5666

Closed
AndreasMadsen wants to merge 1 commit into
nodejs:masterfrom
AndreasMadsen:collab-add-myself
Closed

doc: add AndreasMadsen to collaborators#5666
AndreasMadsen wants to merge 1 commit into
nodejs:masterfrom
AndreasMadsen:collab-add-myself

Conversation

Copy link
Copy Markdown
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Adding myself to the collaborator list

AndreasMadsen added the doc Issues and PRs related to the documentations. label Mar 11, 2016

Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

PR-URL: https://github.com/nodejs/node/pull/5666 LGTM

Copy link
Copy Markdown
Member Author

Landed in 0ed4665

AndreasMadsen deleted the collab-add-myself branch March 11, 2016 22:17

rvagg commented Mar 14, 2016

Copy link
Copy Markdown
Member

Woot! Welcome @AndreasMadsen!

evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>

Copy link
Copy Markdown
Contributor

🎉

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL