FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add thekemkid to collaborators by GlenTiki · Pull Request #5667 · nodejs/node · GitHub

/ node Public

doc: add thekemkid to collaborators - #5667

Merged
GlenTiki merged 1 commit into
nodejs:masterfrom
GlenTiki:add-collaborator-thekemkid
Mar 12, 2016
ConversationCommits (1)ChecksFiles changed
Merged

doc: add thekemkid to collaborators#5667
GlenTiki merged 1 commit into
nodejs:masterfrom
GlenTiki:add-collaborator-thekemkid

Conversation

GlenTiki commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

Description of change

Adding myself to the collaborator list

GlenTiki added the doc Issues and PRs related to the documentations. label Mar 11, 2016

benjamingr commented Mar 11, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

evanlucas commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

Fishrock123 commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

PR-URL: https://github.com/nodejs/node/pull/5667

LGTM!

GlenTiki force-pushed the add-collaborator-thekemkid branch from d12f3a3 to 36178bc Compare March 11, 2016 22:00

cjihrig commented Mar 12, 2016

Copy link
Copy Markdown
Contributor

The second line of the commit message should be blank. Other than that, LGTM.

GlenTiki force-pushed the add-collaborator-thekemkid branch from 36178bc to 2d01078 Compare March 12, 2016 03:32
GlenTiki force-pushed the add-collaborator-thekemkid branch from 2d01078 to dccdd3c Compare March 12, 2016 04:13
doc: add thekemkid to collaborators
4daab7f 
PR-URL: nodejs#5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
GlenTiki force-pushed the add-collaborator-thekemkid branch from dccdd3c to 4daab7f Compare March 12, 2016 12:11
GlenTiki merged commit 4daab7f into nodejs:master Mar 12, 2016

benjamingr commented Mar 12, 2016

Copy link
Copy Markdown
Member

@thekemkid hey, in the future please see https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests - we don't merge using the GitHub merge button. I'm not sure if that's what you did here - but just for future reference.

GlenTiki commented Mar 12, 2016

Copy link
Copy Markdown
Contributor Author

I didn't use the button, as there's no commit (EDIT: merge) message O.o

I rebased my branch onto a local master and pushed that to upstream. I expected to have to close this after pushing, but github closed for me.

rvagg commented Mar 14, 2016

Copy link
Copy Markdown
Member

Welcome @thekemkid! Good to have you on board!

evanlucas mentioned this pull request Mar 14, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
doc: add thekemkid to collaborators
9386c80 
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas mentioned this pull request Mar 14, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
doc: add thekemkid to collaborators
f7aecd6 
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

🎉

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
doc: add thekemkid to collaborators
49292c9 
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
doc: add thekemkid to collaborators
5ab4dfb 
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
doc: add thekemkid to collaborators
0a6e883 
PR-URL: #5667

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL