win,build: support Visual C++ Build Tools 2015 - #5627
Merged
joaocgreis merged 1 commit intoMar 11, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/1888/ node-test-commit-windows-fanned for cherry-picks on *-staging branches: |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#5627
joaocgreis
force-pushed
the
joaocgreis-G39-vcbt-master
branch
from
e01c1b0 to
a693557
Compare
March 11, 2016 11:26
joaocgreis
added a commit
that referenced
this pull request
Mar 11, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
joaocgreis
added a commit
that referenced
this pull request
Mar 11, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
joaocgreis
added a commit
that referenced
this pull request
Mar 11, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #5627
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select you VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
MylesBorins
pushed a commit
that referenced
this pull request
Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
MylesBorins
pushed a commit
that referenced
this pull request
Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
PR-URL: #5835
This was referenced Mar 31, 2016
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Invoke MSBuild specifying the target platform as generated by Gyp. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs/node#5627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
this change (including linting)?
Affected core subsystem(s)
win, build
Description of change
To build with Microsoft Visual C++ Build Tools 2015 Technical Preview Update 2 RC, msbuild should be invoked with a parameter specifying the platform (/p:Platform=). This is necessary because vcvarsall.bat sets a default platform that is not present in the solution generated by Gyp, failing the build.
CI machines run a previous version of VCBT, with a version of vcvarsall.bat modified to be able to build node. With the updated version in Update 2, only this change is needed to build with unmodified VCBT.
This is a trivial cherry-pick for v4-staging, v0.12-staging and v0.10-staging.
cc @nodejs/platform-windows