FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc, installer: win - new logo in installer; optim .jpg by eljefedelrodeodeljefe · Pull Request #5531 · nodejs/node · GitHub

/ node Public

doc, installer: win - new logo in installer; optim .jpg - #5531

Closed
eljefedelrodeodeljefe wants to merge 1 commit into
nodejs:masterfrom
eljefedelrodeodeljefe:installer/win-new-logo
ConversationCommits (1)ChecksFiles changed
Closed

doc, installer: win - new logo in installer; optim .jpg#5531
eljefedelrodeodeljefe wants to merge 1 commit into
nodejs:masterfrom
eljefedelrodeodeljefe:installer/win-new-logo

Conversation

eljefedelrodeodeljefe commented Mar 2, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

tools

Description of change

Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.

had to close #5391 and reopen here due to rebase foo and GH not being able to reopen closed force-pushed branches. Sorry.

/cc @rvagg can you give Jenkins a try? Could build locally.

mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Mar 2, 2016

rvagg commented Mar 3, 2016

Copy link
Copy Markdown
Member

https://nodejs.org/download/test/v6.0.0-test20160303761abde90c/

I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe?

eljefedelrodeodeljefe commented Mar 3, 2016

Copy link
Copy Markdown
Contributor Author

On parallels, Win10:

x64

x86

rvagg commented Mar 3, 2016

Copy link
Copy Markdown
Member

Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour?

joaocgreis commented Mar 3, 2016

Copy link
Copy Markdown
Member

Tested both installers on Windows 2008 R2, both look fine, as the screenshots above for Windows 10.

doc, installer: win - new logo in installer; optim .jpg
53ba5e7 
doc, installer: change stripe color to RGB 68 136 62

eljefedelrodeodeljefe commented Mar 4, 2016

Copy link
Copy Markdown
Contributor Author

Changed the color to the middle tone. See RGB in commit. Squashed the thing.

@rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas.

Fishrock123 commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

Could you make sure to run the image though imageoptim / optipng (also for jpeg) or similar tools? (Make sure you don't loose quality though)

eljefedelrodeodeljefe commented Mar 4, 2016

Copy link
Copy Markdown
Contributor Author

ran it through imageoptim. Do you see anything specific?

Fishrock123 commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

No I just wanted to make sure, less binary bytes in git.

eljefedelrodeodeljefe commented Mar 4, 2016

Copy link
Copy Markdown
Contributor Author

Ah, alright. FYI It's 7 and 9kb now, with 9-14% optimization. When I did it with .png it was even over 30%.

ChALkeR commented Mar 5, 2016

Copy link
Copy Markdown
Member

@Fishrock123 Btw, just running optipng does not give the best result. Even running plain simple advdef afterwards saves a few more bytes. Note that advdef is not even a png optimizer, it does not touch the internal png structure. It just recompresses things.

silverwind commented Mar 5, 2016

Copy link
Copy Markdown
Contributor

LGTM

rvagg commented Mar 7, 2016

Copy link
Copy Markdown
Member

lgtm

landed @ 44c9751 thanks @eljefedelrodeodeljefe

rvagg closed this Mar 7, 2016
rvagg pushed a commit that referenced this pull request Mar 7, 2016
build: update Node.js logo on Win installer
44c9751 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 mentioned this pull request Mar 7, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
build: update Node.js logo on Win installer
dadd55f 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
build: update Node.js logo on Win installer
2abf866 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
build: update Node.js logo on Win installer
b2b6ca3 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
build: update Node.js logo on Win installer
9cbd062 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
build: update Node.js logo on Win installer
1165ecc 
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins mentioned this pull request Mar 21, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
2016-03-21, Version v4.4.1 'Argon' (LTS)
30b366d 
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select you VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
2016-03-22, Version v4.4.1 'Argon' (LTS)
5368455 
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325
MylesBorins pushed a commit that referenced this pull request Mar 22, 2016
2016-03-22, Version v4.4.1 'Argon' (LTS)
2c67289 
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

PR-URL: #5835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL