| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Could these be .png? I think there was maybe a windows issue about that? @eljefedelrodeodeljefe Could you ensure that these are run though tools like imageoptim to reduce their size as much as possible (while keeping quality)? |
Sorry, something went wrong.
|
I've got several high res versions of the logo, we're working to get the downloads page on the website updated with them. You'll see them posted here soon nodejs/nodejs.org#526 (comment) |
Sorry, something went wrong.
|
@Fishrock123 can do it in .png, would be a change from .jpg though. I ran it from Adobe Illustrator / Photoshop. But will try to optimise further with something like it. @mikeal took the vector formats out of the .pdf https://drive.google.com/folderview?id=0B2SAGsHi4DjIcHB0cTZZcXFZNG8&usp=sharing |
Sorry, something went wrong.
|
saved 20% space, output looks good to me still. |
Sorry, something went wrong.
|
I'm pretty sure we've had problems with trying to do .png in the past, I'll push out a test build as soon as we have Jenkins back /cc @nodejs/platform-windows |
Sorry, something went wrong.
|
.png is a problem for Windows 7 / 2008, according to MSDN it is only supported on Windows 8 and after. I confirmed it, the installer appears with a gray background. @eljefedelrodeodeljefe the last post on http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/BMP-and-JPEG-td3503935.html suggests compressed indexed .bmp, you could give it a try, or just use .jpg. |
Sorry, something went wrong.
revert to jpg extension
|
Sorry. Didn't mean to close. Did a mistake rebasing. Will push in a minute. referenced new PR |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description of change
Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.
Pull Request check-list
Please make sure to review and check all of these items:
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open.
Affected core subsystem(s)
none