FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm,src: add property query interceptors by legendecas · Pull Request #53517 · nodejs/node · GitHub

/ node Public

vm,src: add property query interceptors - #53517

Closed
legendecas wants to merge 3 commits into
nodejs:mainfrom
legendecas:vm/interceptor
ConversationCommits (3)ChecksFiles changed
Closed

vm,src: add property query interceptors#53517
legendecas wants to merge 3 commits into
nodejs:mainfrom
legendecas:vm/interceptor

Conversation

legendecas commented Jun 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

src: remove unused ContextifyContext::WeakCallback

ContextifyContext::WeakCallback is unused.

vm,src: add property query interceptors

Distinguish named property and indexed property when enumerating keys
and handle query interceptions.

Co-Authored-By: Michaël Zasso targos@protonmail.com
Fixes: #52720

Re-landing #53172

/cc @nodejs/vm

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 20, 2024
legendecas added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 20, 2024
vm,src: add property query interceptors
38c543d 
Distinguish named property and indexed property when enumerating keys
and handle query interceptions.

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
legendecas requested review from joyeecheung and targos June 20, 2024 12:23
legendecas added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. request-ci Add this label to start a Jenkins CI on a PR. and removed dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v18.x labels Jun 20, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2024

nodejs-github-bot commented Jun 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59910/

nodejs-github-bot commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59948/

joyeecheung reviewed Jun 25, 2024
View reviewed changes
Comment thread src/node_contextify.cc
legendecas mentioned this pull request Jul 1, 2024
Closed
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024

nodejs-github-bot commented Jul 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60105/

legendecas commented Jul 5, 2024

Copy link
Copy Markdown
Member Author

@joyeecheung would you mind taking a look again? thanks!

nodejs-github-bot commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60183/

legendecas added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 9, 2024
legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024

nodejs-github-bot commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2b068ff...c0962dc

nodejs-github-bot pushed a commit that referenced this pull request Jul 9, 2024
src: remove unused ContextifyContext::WeakCallback
213fea0 
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 9, 2024
vm,src: add property query interceptors
c0962dc 
Distinguish named property and indexed property when enumerating keys
and handle query interceptions.

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
legendecas deleted the vm/interceptor branch July 9, 2024 09:47
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
src: remove unused ContextifyContext::WeakCallback
d294ac3 
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
vm,src: add property query interceptors
d0bf142 
Distinguish named property and indexed property when enumerating keys
and handle query interceptions.

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
src: remove unused ContextifyContext::WeakCallback
021e2cf 
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
vm,src: add property query interceptors
9fd976b 
Distinguish named property and indexed property when enumerating keys
and handle query interceptions.

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #53517
Fixes: #52720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
avivkeller mentioned this pull request Aug 19, 2024
Closed

legendecas commented Aug 19, 2024

Copy link
Copy Markdown
Member Author

Label as https://github.com/nodejs/node/labels/dont-land-on-v20.x for breakage in #54436.

legendecas commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

Removed https://github.com/nodejs/node/labels/dont-land-on-v20.x since it is proved to be addressable in userland and can fix more compliance issues.

legendecas mentioned this pull request Sep 3, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent presence of property in contextified object

4 participants

Back | FazBrowse Home | New Git URL