FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm,src: add property query interceptors by targos · Pull Request #53172 · nodejs/node · GitHub

/ node Public

vm,src: add property query interceptors - #53172

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-52720
Jun 4, 2024
ConversationCommits (2)ChecksFiles changed
Merged

vm,src: add property query interceptors#53172
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-52720

Conversation

targos commented May 27, 2024

Copy link
Copy Markdown
Member

Fixes: #52720

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 27, 2024

targos commented May 27, 2024

Copy link
Copy Markdown
Member Author

/cc @nodejs/cpp-reviewers

targos mentioned this pull request May 27, 2024
Closed

targos commented May 28, 2024

Copy link
Copy Markdown
Member Author

@nodejs/vm

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59488/

targos added dont-land-on-v18.x commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 28, 2024

targos commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

Can someone else please review?

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
nodejs-github-bot merged commit d1f18b0 into nodejs:main Jun 4, 2024

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in d1f18b0

targos deleted the fix-52720 branch June 4, 2024 06:55
tsctx mentioned this pull request Jun 5, 2024
Closed
targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 5, 2024
targos mentioned this pull request Jun 5, 2024
Merged
legendecas mentioned this pull request Jun 20, 2024
Closed
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
vm,src: add property query interceptors
b8fbf34 
Fixes: nodejs#52720
PR-URL: nodejs#53172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 mentioned this pull request Oct 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent presence of property in contextified object

3 participants

Back | FazBrowse Home | New Git URL