FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "vm,src: add property query interceptors" by targos · Pull Request #53348 · nodejs/node · GitHub

/ node Public

Revert "vm,src: add property query interceptors" - #53348

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-regression
Jun 6, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Revert "vm,src: add property query interceptors"#53348
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-regression

Conversation

targos commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit d1f18b0.

Closes: #53346

Reverts PR #53172

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 5, 2024
targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 5, 2024

github-actions Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 5, 2024
targos mentioned this pull request Jun 5, 2024
Closed
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024

nodejs-github-bot commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59661/

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 5, 2024

nodejs-github-bot commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59669/

nodejs-github-bot commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59671/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
nodejs-github-bot merged commit 35b8e5c into nodejs:main Jun 6, 2024

nodejs-github-bot commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in 35b8e5c

targos deleted the fix-regression branch June 10, 2024 09:42
legendecas mentioned this pull request Jun 20, 2024
Closed
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
Revert "vm,src: add property query interceptors"
ffa2586 
This reverts commit d1f18b0.

Closes: nodejs#53346
PR-URL: nodejs#53348
Fixes: nodejs#53346
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 mentioned this pull request Oct 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
H4ad H4ad approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vm module regression

4 participants

Back | FazBrowse Home | New Git URL