FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: update wpt by avivkeller · Pull Request #54468 · nodejs/node · GitHub

/ node Public

test: update wpt - #54468

Closed
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:wpt
ConversationCommits (2)ChecksFiles changed
Closed

test: update wpt#54468
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:wpt

Conversation

avivkeller commented Aug 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR updates the WPT files.

Note the following behavioral differences between Node.js and WPT:

test-structured-clone.js

Comparison: https://wpt.fyi/results/html/webappapis/structured-clone/structured-clone.any.html
See: #55120

nodejs-github-bot commented Aug 20, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 20, 2024
avivkeller added web-standards Issues and PRs related to Web APIs commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. wip Issues and PRs that are still a work in progress. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Aug 20, 2024
This was referenced Aug 23, 2024
Merged
Closed
panva reviewed Aug 26, 2024
View reviewed changes
Comment thread test/wpt/status/WebCryptoAPI.json Outdated
panva added a commit to panva/node that referenced this pull request Aug 27, 2024
test,crypto: update WebCryptoAPI WPT
e36c683 
Refs: nodejs#54572
Refs: nodejs#54468
panva mentioned this pull request Aug 27, 2024
Merged
avivkeller added the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2024

avivkeller commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until #54468 #54593 does.

panva commented Aug 27, 2024

Copy link
Copy Markdown
Member

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until #54468 does.

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2024

avivkeller commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

Right, haha. I just to remove the WebCryptoAPI changes, and then fix the other failures...

This was referenced Aug 28, 2024
Closed
Closed
nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2024
test,crypto: update WebCryptoAPI WPT
fc02b88 
Refs: #54572
Refs: #54468
PR-URL: #54593
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
avivkeller added the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2024

avivkeller commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

FWIW This is currently blocked by the followings issues attempting to bring Node.js up-to-specification:
#54466 (and #54601)
#54617
#54602 #54603

panva commented Aug 29, 2024

Copy link
Copy Markdown
Member

If you've opened the specific issues for nonconform behaviours and can add them as a note to the expectation files then this is fine to proceed.

avivkeller commented Aug 29, 2024

Copy link
Copy Markdown
Member Author

Good to know. Thanks! I'll update this and proceed.

avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2024
avivkeller mentioned this pull request Aug 29, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
test,crypto: update WebCryptoAPI WPT
5ee234a 
Refs: #54572
Refs: #54468
PR-URL: #54593
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jazelly mentioned this pull request Sep 7, 2024
Closed
avivkeller removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 7, 2024
jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024

nodejs-github-bot commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62129/

avivkeller added test Issues and PRs related to the tests. and removed wip Issues and PRs that are still a work in progress. labels Sep 25, 2024
avivkeller marked this pull request as ready for review September 25, 2024 20:08
avivkeller commented Sep 25, 2024
View reviewed changes
Comment thread test/wpt/status/html/webappapis/structured-clone.json Outdated
Comment on lines 4 to 12

avivkeller Sep 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Review note:
File basic and A subclass instance will deserialize as its closest serializable superclass are being monitored at #47612

Growable SharedArrayBuffer is failing WPT because the test expects that SharedArrayBuffer extends ArrayBuffer, but it does not (AFAICT in Chromium and Node.js). I've manually tested that the behavior the WPT expects (regarding the clone, not the extension) passes on Node.js.

Serializing a non-serializable platform object fails is being monitored at #55120

avivkeller added the needs-ci PRs that need a full CI run. label Sep 25, 2024

codecov Bot commented Sep 25, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (bdddc04) to head (341b6c2).
Report is 60 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54468      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183856   183856              
  Branches    35856    35853       -3     
==========================================
- Hits       162255   162252       -3     
+ Misses      14895    14883      -12     
- Partials     6706     6721      +15

see 24 files with indirect coverage changes

avivkeller commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

I'm closing this in favor of opening each update seperately, so some of them can be backported (if needed?)

avivkeller closed this Sep 30, 2024
panva added a commit to panva/node that referenced this pull request Jun 5, 2025
test,crypto: update WebCryptoAPI WPT
29ce454 
Refs: nodejs#54572
Refs: nodejs#54468
PR-URL: nodejs#54593
Refs: nodejs#54572
Refs: nodejs#54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 9, 2025
test,crypto: update WebCryptoAPI WPT
7da8602 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
test,crypto: update WebCryptoAPI WPT
50ab099 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
test,crypto: update WebCryptoAPI WPT
8237346 
Refs: #54572
Refs: #54468
PR-URL: #54593
Backport-PR-URL: #58589
Refs: #54572
Refs: #54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva left review comments

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL