FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: handle errors correctly in webstorage by targos · Pull Request #54544 · nodejs/node · GitHub

/ node Public

src: handle errors correctly in webstorage - #54544

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:maybe-webstorage
Aug 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

src: handle errors correctly in webstorage#54544
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:maybe-webstorage

Conversation

targos commented Aug 24, 2024

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 24, 2024

codecov Bot commented Aug 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (c062b52) to head (9c5158f).
Report is 830 commits behind head on main.

Files with missing lines Patch % Lines
src/node_webstorage.cc 50.00% 9 Missing and 28 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54544      +/-   ##
==========================================
- Coverage   87.32%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182602   182599       -3     
  Branches    35033    35038       +5     
==========================================
- Hits       159461   159458       -3     
- Misses      16396    16403       +7     
+ Partials     6745     6738       -7
Files with missing lines Coverage Δ
src/node_webstorage.h 40.00% <ø> (ø)
src/node_webstorage.cc 72.20% <50.00%> (-1.44%) ⬇️

... and 21 files with indirect coverage changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61442/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024
avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 25, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2024
nodejs-github-bot merged commit 4f1c27a into nodejs:main Aug 26, 2024

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

Landed in 4f1c27a

targos deleted the maybe-webstorage branch August 26, 2024 17:43

RafaelGSS commented Aug 30, 2024

Copy link
Copy Markdown
Member

@targos This commit didn't land cleanly on v22.x-staging due to #54418. Would you mind creating a manual backport?

RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Aug 30, 2024
targos added backport-open-v22.x Indicate that the PR has an open backport and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Sep 1, 2024

targos commented Sep 1, 2024

Copy link
Copy Markdown
Member Author

Backport PR: #54683

targos added a commit to targos/node that referenced this pull request Sep 16, 2024
src: handle errors correctly in webstorage
87ece12 
PR-URL: nodejs#54544
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos added a commit that referenced this pull request Oct 6, 2024
src: handle errors correctly in webstorage
0999949 
PR-URL: #54544
Backport-PR-URL: #54683
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
benjamingr benjamingr approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL