[v22.x] src: handle errors correctly in webstorage - #54683
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
commented
Sep 1, 2024
Comment thread
src/node_webstorage.cc
Outdated
targos
marked this pull request as draft
September 1, 2024 09:38
targos
force-pushed
the
backport-54544-v22
branch
from
d8416b7 to
170a9ae
Compare
September 5, 2024 16:07
Copy link
Copy Markdown
Member
Author
|
I fixed the crash with a fallback to undefined in the interceptor, but I think there's a bug in V8 because that's what the documentation says: * If the interceptor handles the request (i.e. the property should not be * looked up beyond the interceptor) it should * - (optionally) use info.GetReturnValue().Set()` to set the return value * (by default the result is set to v8::Undefined), * - return `Intercepted::kYes`. * If the interceptor does not handle the request it must return * `Intercepted::kNo` and it must not produce side effects. |
Sorry, something went wrong.
targos
marked this pull request as ready for review
September 5, 2024 16:09
jasnell
approved these changes
Sep 5, 2024
Copy link
Copy Markdown
Member
Author
|
I'm not sure what to do with the coverage job. It pretends that JS coverage went down, but this PR doesn't touch any JS file. |
Sorry, something went wrong.
aduh95
force-pushed
the
v22.x-staging
branch
from
fec390e to
2b68c30
Compare
September 13, 2024 22:27
PR-URL: nodejs#54544 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
force-pushed
the
backport-54544-v22
branch
from
170a9ae to
87ece12
Compare
September 16, 2024 06:35
Copy link
Copy Markdown
Member
Author
|
Rebased |
Sorry, something went wrong.
RafaelGSS
force-pushed
the
v22.x-staging
branch
from
8997e69 to
beb4925
Compare
September 17, 2024 02:21
Copy link
Copy Markdown
Member
Author
|
#54966 is also affected by the coverage drop |
Sorry, something went wrong.
RafaelGSS
force-pushed
the
v22.x-staging
branch
from
beb4925 to
93116dd
Compare
September 17, 2024 14:18
Copy link
Copy Markdown
Member
Author
|
@RafaelGSS Should I open an issue for the coverage? The difference between v22.x and main is non-negligible. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.