Review requested:

• @nodejs/net

CC @jazelly

@jakecastelli are you looking into having this fast tracked?

Fast-track has been requested by @jakecastelli. Please 👍 to approve.

@jakecastelli your own 👍 doesn't count for the fast-track request. So another collaborator is needed to fast track.

@jakecastelli your own 👍 doesn't count for the fast-track request. So another collaborator is needed to fast track.

Thanks for the heads up 🙏

CI: https://ci.nodejs.org/job/node-test-pull-request/61454/

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (7fea010) to head (c3653d2).
Report is 326 commits behind head on main.

@@            Coverage Diff             @@
##             main   #54554      +/-   ##
==========================================
+ Coverage   87.32%   87.35%   +0.02%     
==========================================
  Files         649      649              
  Lines      182618   182618              
  Branches    35033    35045      +12     
==========================================
+ Hits       159475   159519      +44     
+ Misses      16407    16382      -25     
+ Partials     6736     6717      -19     

... and 27 files with indirect coverage changes

Can't we simply fix the test instead of reverting this?

See #54556 as well

Removing fast-track PRs that do not need to wait for 48 hours to land. as the other PR was merged, which IIUC also fixes the CI. Do we still want to land this?

Thanks guys for looking into this 🙏 it was nearly 1:30 A.M. when I found this issue and I wasn't sure if there is going to be more issues, the safest way comes to my mind was raising the issue, reverting (as I knew prior to this commit it was green), run CI, maybe land when I wake up 😄 but thanks @lpinca for looking into and fixing it and also everyone else who helped here!

Do we still want to land this?

Since the Github Actions / CI is green, we don't want to land this anymore 👍 if there are bugs, we can always send patches instead.

Update: Yes, we found bigger issue with that commit, and we need to revert the commit.

CI: https://ci.nodejs.org/job/node-test-pull-request/61471/

CI: https://ci.nodejs.org/job/node-test-pull-request/61477/

Looks like we started the rerun around the same time @lpinca, I will cancel mine (as mine appears to be late 😄)
Update: cancelled and marked as outdated.

test-http2-socket-close has been extremely flaky 😞

CI: https://ci.nodejs.org/job/node-test-pull-request/61486/

CI: https://ci.nodejs.org/job/node-test-pull-request/61491/ 💚

- Loading data for nodejs/node/pull/54554
✔  Done loading data for nodejs/node/pull/54554
----------------------------------- PR info ------------------------------------
Title      Revert "net: validate host name for server listen" (#54554)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jakecastelli:revert-52322aa -> nodejs:main
Labels     net, needs-ci, revert
Commits    1
 - Revert "net: validate host name for server listen"
Committers 1
 - jakecastelli <jake.yuesong@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54554
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54554
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 25 Aug 2024 15:48:40 GMT
   ✔  Approvals: 5
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259334489
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259336303
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54554#pullrequestreview-2261077656
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/54554#pullrequestreview-2259348797
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54554#pullrequestreview-2261429112
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-08-26T14:06:43Z: https://ci.nodejs.org/job/node-test-pull-request/61491/
- Querying data for job/node-test-pull-request/61491/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Last GitHub CI failed

This is not true 😞 landing manually now

Landed in 4f14eb1

Ok