test: use valid hostnames - #54556
Merged
nodejs-github-bot merged 1 commit intoAug 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: nodejs#54554
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #54556 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 649 649
Lines 182618 182626 +8
Branches 35033 35043 +10
=======================================
+ Hits 159475 159489 +14
+ Misses 16407 16402 -5
+ Partials 6736 6735 -1 |
Sorry, something went wrong.
anonrig
approved these changes
Aug 25, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This issue was causing test failures left and right, should this be fast tracked? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Aug 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use valid hostnames in
test/sequential/test-net-server-listen-ipv6-link-local.js.
Refs: #54554