meta: remove build-windows.yml - #54662
Merged
nodejs-github-bot merged 1 commit intoSep 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CC @nodejs/platform-windows |
Sorry, something went wrong.
jasnell
approved these changes
Aug 31, 2024
StefanStojanovic
approved these changes
Sep 9, 2024
Copy link
Copy Markdown
Member
Author
|
Is this good to land? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54662 ✔ Done loading data for nodejs/node/pull/54662 ----------------------------------- PR info ------------------------------------ Title meta: remove `build-windows.yml` (#54662) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-117 -> nodejs:main Labels windows, meta Commits 1 - meta: remove `build-windows.yml` Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - meta: remove `build-windows.yml` ℹ This PR was created on Fri, 30 Aug 2024 15:55:41 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54662#pullrequestreview-2274122543 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/54662#pullrequestreview-2289493802 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10917631736 |
Sorry, something went wrong.
marco-ippolito
approved these changes
Sep 18, 2024
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 11, 2025
PR-URL: #54662 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the actions done in build-windows.yml are also done in coverage-windows.yml, this means that the separate building of windows in this action is redundant.
node/.github/workflows/coverage-windows.yml
Lines 46 to 58 in 2bfc9e4
is the same as
node/.github/workflows/build-windows.yml
Lines 41 to 53 in 2bfc9e4