| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
PR-URL: #57994 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
PR-URL: #57994 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
If the buffer allocation fails due to insufficient memory, there is no point continue testing toString(). PR-URL: #58415 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The test only cares about whether a size outside the range of the 32-bit signed integers works with Blob.prototype.slice(). If it fails due to allocation failure when the system does not have enough memory, the test should just be skipped. The test previously only skipped the test when the allocation failure happens during allocation of the buffer source, but it could also happen during Blob.prototype.slice(). PR-URL: #58414 Fixes: #57235 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This is the certdata.txt[0] from NSS 3.108. This is the version of NSS that shipped in Firefox 136.0 on 2025-03-04. Certificates added: - D-TRUST BR Root CA 2 2023 - D-TRUST EV Root CA 2 2023 Certificates removed: - SwissSign Silver CA - G2 [0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_108_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #57381 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #55296 Reviewed-By: James M Snell <jasnell@gmail.com>
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #55892 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
PR-URL: #56142 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #56428 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #56764 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #57265 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #57384 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57620 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This special case was missed in the previous changes to this file. Refs: #55514 Refs: #42923 Fixes: #57669 PR-URL: #57695 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #57742 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-Authored-By: richardlau - Richard Lau <rlau@redhat.com> PR-URL: #58090 Refs: #57934 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Review requested:
|
Sorry, something went wrong.
Notable changes: crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * stabilize util.styleText (Rafael Gonzaga) #56265 * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 PR-URL: #58588
Sorry, something went wrong.
|
It seems fine to just skip the test on rhel8+ppc, that's only a tier 2 platform and I doubt how many users would actually be affected by this. |
Sorry, something went wrong.
|
Technically Tier 2: These platforms represent smaller segments of the Node.js user base. The Node.js Build Working Group maintains infrastructure for full test coverage. Test failures on tier 2 platforms will block releases. Infrastructure issues may delay the release of binaries for these platforms. Test failures on tier 2 platforms will block releases Is it ok to mark all these tests as skip? [sequential.test-single-executable-application](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application/) [sequential.test-single-executable-application-assets](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_assets/) [sequential.test-single-executable-application-assets-raw](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_assets_raw/) [sequential.test-single-executable-application-disable-experimental-sea-warning](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_disable_experimental_sea_warning/) [sequential.test-single-executable-application-empty](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_empty/) [sequential.test-single-executable-application-snapshot](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_snapshot/) [sequential.test-single-executable-application-snapshot-and-code-cache](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_snapshot_and_code_cache/) [sequential.test-single-executable-application-snapshot-worker](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_snapshot_worker/) [sequential.test-single-executable-application-use-code-cache](https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/59518/testReport/junit/(root)/sequential/test_single_executable_application_use_code_cache/) |
Sorry, something went wrong.
|
I'm also okay with marking these tests as skip on v20.x for rhel8-ppc64le because SEA is experimental. Also, arm64 is tier 1 on Linux and macOS but we are already skipping some tests on main - node/test/parallel/parallel.status Lines 57 to 60 in 214e4db |
Sorry, something went wrong.
|
I opened a PR to skip these tests PTAL #58761 |
Sorry, something went wrong.
|
I'm ok with skipping the tests since SEA is experimental and I believe that there is likely low usage on power systems at this point |
Sorry, something went wrong.
PR-URL: #58761 Refs: #58588 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Notable changes: crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 PR-URL: #58588
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
Finally a green CI 🥹 |
Sorry, something went wrong.
|
RELEASE CI is green lets release this! |
Sorry, something went wrong.
Notable changes: crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 PR-URL: #58588
| Back | FazBrowse Home | New Git URL |
2025-06-23, Version 20.19.3 'Iron' (LTS), @marco-ippolito
Notable Changes
Commits