FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: force GC in test-file-write-stream4 by lpinca · Pull Request #57930 · nodejs/node · GitHub

/ node Public

test: force GC in test-file-write-stream4 - #57930

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:deflake/test-file-write-stream4
Apr 20, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test: force GC in test-file-write-stream4#57930
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:deflake/test-file-write-stream4

Conversation

lpinca commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Reduce test/parallel/test-file-write-stream4.js flakiness.

Refs: #57927

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 18, 2025

lpinca commented Apr 18, 2025

Copy link
Copy Markdown
Member Author

Alternative to #57927.

lpinca commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think we can land this before #57927, and see if it has the desired effect. If it doesn't, we can revert and land #57927 instead.

jasnell approved these changes Apr 18, 2025
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure that this and the PR marking this test as flaky are mutually exclusive. We can do both then remove the flaky flag once we believe it has been fixed.

lpinca force-pushed the deflake/test-file-write-stream4 branch 2 times, most recently from 4c82143 to 563da32 Compare April 18, 2025 18:26

lpinca commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

In my opinion, landing both does not make much sense.

lpinca commented Apr 18, 2025

Copy link
Copy Markdown
Member Author 
$ npx envinfo --system

  System:
    OS: macOS 15.4.1
    CPU: (16) x64 Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz
    Memory: 1.66 GB / 32.00 GB
    Shell: 5.2.37 - /usr/local/bin/bash

Before the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
=== release test-file-write-stream4 ===                   
Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---


=== release test-file-write-stream4 ===                   
Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---

...

[04:15|% 100|+ 982|-  18]: Done

Failed tests:
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js

...

After the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
[01:13|% 100|+ 1000|-   0]: Done                          

All tests passed.

codecov Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (52d95f5) to head (5bfd30f).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57930      +/-   ##
==========================================
+ Coverage   90.26%   90.27%   +0.01%     
==========================================
  Files         630      630              
  Lines      185933   185933              
  Branches    36450    36443       -7     
==========================================
+ Hits       167829   167853      +24     
+ Misses      10972    10964       -8     
+ Partials     7132     7116      -16

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66356/

test: force GC in test-file-write-stream4
5bfd30f 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: nodejs#57927
lpinca force-pushed the deflake/test-file-write-stream4 branch from 563da32 to 5bfd30f Compare April 19, 2025 07:59
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66358/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2025
nodejs-github-bot merged commit 422529a into nodejs:main Apr 20, 2025

nodejs-github-bot commented Apr 20, 2025

Copy link
Copy Markdown
Collaborator

Landed in 422529a

lpinca deleted the deflake/test-file-write-stream4 branch April 20, 2025 18:37
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
test: force GC in test-file-write-stream4
9ffdfef 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
test: force GC in test-file-write-stream4
f2fd19e 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: force GC in test-file-write-stream4
6a3a256 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: force GC in test-file-write-stream4
df17dc6 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
test: force GC in test-file-write-stream4
4aa44a2 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
test: force GC in test-file-write-stream4
24846bc 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
test: force GC in test-file-write-stream4
0c6c448 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
test: force GC in test-file-write-stream4
619b0c0 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
test: force GC in test-file-write-stream4
92dce6e 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
test: force GC in test-file-write-stream4
73b7e05 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
test: force GC in test-file-write-stream4
6a2258b 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito mentioned this pull request Jun 5, 2025
Merged
ghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
test: force GC in test-file-write-stream4
5d1dc29 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
test: force GC in test-file-write-stream4
275ea8e 
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
anonrig anonrig approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL